Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21205 to 7.x: [Winlogbeat] Add acceptable event log keys to winlog #21430

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Sep 30, 2020

Cherry-pick of PR #21205 to 7.x branch. Original message:

What does this PR do?

Adds 'id', 'meta' and 'revision' as acceptable config keys for winlog
input.

Why is it important?

when running filebeat under elasti-agent 'id', 'meta' and 'revision'
are sent as config keys to the winlog input type. This change allows
those config keys to pass validation.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

when running filebeat under elasti-agent 'id', 'meta' and 'revision'
are sent as config keys to the winlog input type.  This change allows
those config keys to pass validation.

(cherry picked from commit 499cc94)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 30, 2020
@leehinman leehinman merged commit f928a2c into elastic:7.x Sep 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21430 opened]

  • Start Time: 2020-09-30T18:08:55.705+0000

  • Duration: 40 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 277
Skipped 1
Total 278

@leehinman leehinman deleted the backport_21205_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants