Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22055 to 7.10: revert WSS process reporting for windows #22064

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 21, 2020

Cherry-pick of PR #22055 to 7.10 branch. Original message:

What does this PR do?

This reverts the change to report system.process.memory.rss as wss on windows.

Why is it important?

@mukeshelastic and I decided that this change was unnecessary. We're reporting what is fundamentally the same metric as two different fields depending on the OS. This is particularly burdensome for users wanting to make queries against these fiends across OS. When we have the opportunity to make breaking changes, we may want to rename this to system.process.memory.pct or something similar.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR and build on windows
  • Ensure that memory.rss is present on the system/process metricset

* revert WSS process reporting for windows

* add changelog

(cherry picked from commit ba2b2f9)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2020
@fearful-symmetry fearful-symmetry requested a review from a team October 21, 2020 18:49
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22064 opened]

  • Start Time: 2020-10-21T18:50:27.953+0000

  • Duration: 91 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 2237
Skipped 505
Total 2742

@fearful-symmetry fearful-symmetry merged commit 18d9938 into elastic:7.10 Oct 21, 2020
@zube zube bot removed the [zube]: Done label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants