Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21835 to 7.x: Use symlink path for reexecutions #22100

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #21835 to 7.x branch. Original message:

What does this PR do?

This PR initiates reexec manager with the path to symlink instead of os.Executable which might point to actual executable even if executed using symlink. This behavior leads to reexecing into same binary/version even after upgrade is done.

Tested on linux/windows.
This happens on some OSes as behavior differs in evaluating symlinks. Some refer to symlink file as a process executable some follow symlink and refer to an actual executable.

This is visible during upgrade when upgrade is successfully finished but after reboot it boots up same process (visible as version unchanged in fleet UI).

Why is it important?

Upgrade scenario
Fixes: #21935

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Ingest Manager] Use symlink path for reexecutions (elastic#21835)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 22, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22100 opened]

  • Start Time: 2020-10-22T15:15:45.905+0000

  • Duration: 38 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 1394
Skipped 4
Total 1398

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit a975814 into elastic:7.x Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants