Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21044 to 7.10: Add support for different Azure Cloud environments in the metricbeat azure module #22264

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 29, 2020

Cherry-pick of PR #21044 to 7.10 branch. Original message:

What does this PR do?

Adds support for different Azure Cloud environments in the metricbeat azure module

Adds 2 config options (similar to the filebeat azure module):

resource_manager_endpoint ::
string
Optional, by default the azure public environment is being used, to override, users can provide a specific resource manager endpoint in order to use a different azure environment.
Ex:
https://management.chinacloudapi.cn for azure ChinaCloud
https://management.microsoftazure.de for azure GermanCloud
https://management.azure.com for azure PublicCloud
https://management.usgovcloudapi.net for azure USGovernmentCloud

active_directory_endpoint ::
string
Optional, by default the associated active directory endpoint to the resource manager endpoint is being used, to override, users can provide a specific active directory endpoint in order to use a different azure environment.
Ex:
https://login.microsoftonline.com for azure ChinaCloud
https://login.microsoftonline.us for azure GermanCloud
https://login.chinacloudapi.cn for azure PublicCloud
https://login.microsoftonline.de for azure USGovernmentCloud

Why is it important?

Adds support for different Azure Cloud environments in the metricbeat azure module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…azure module (elastic#21044)

* mofidy doc

* work

* changelog

* fix url

* work

* fmt update

* err

(cherry picked from commit 554d564)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2020
@narph narph self-assigned this Oct 29, 2020
@narph narph added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team v7.10.0 labels Oct 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2020
@zube zube bot added [zube]: Inbox needs_team Indicates that the issue/PR needs a Team:* label [zube]: In Review and removed [zube]: In Review [zube]: Inbox needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2020
@botelastic
Copy link

botelastic bot commented Oct 29, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2658
Skipped 579
Total 3237

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22264 opened]

  • Start Time: 2020-10-29T14:05:18.383+0000

  • Duration: 67 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 2658
Skipped 579
Total 3237

@narph narph merged commit 6078d4c into elastic:7.10 Oct 30, 2020
@narph narph deleted the backport_21044_7.10 branch October 30, 2020 08:29
@zube zube bot removed the [zube]: Done label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants