Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][Fortinet] Fixing kv split for when assign-ip is not an IP and for date checking when eventtime is missing #22361

Merged
merged 3 commits into from
Nov 2, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 2, 2020

What does this PR do?

Since the KV processor does typechecking while performing the splitting operations, it will fail if the assignIP field is of type string, even though it is removed later in the pipeline when its not in the correct format. This change moves the KV split to a temp field to bypass the datatype checking, and performs a check against the IP field before renaming the fields to its correct placement.

Why is it important?

Fixes an issue with KV in cases where eventtime is missing and assignip is not in the correct datatype.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 2, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22361 updated]

  • Start Time: 2020-11-02T19:48:04.740+0000

  • Duration: 51 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@leehinman leehinman merged commit 120f931 into elastic:master Nov 2, 2020
leehinman pushed a commit to leehinman/beats that referenced this pull request Nov 2, 2020
…and for date checking when eventtime is missing (elastic#22361)

* fixing assignip and making sure it does not error on missing eventtime field

* updating changelog

(cherry picked from commit 120f931)
leehinman added a commit that referenced this pull request Nov 3, 2020
…and for date checking when eventtime is missing (#22361) (#22363)

* fixing assignip and making sure it does not error on missing eventtime field

* updating changelog

(cherry picked from commit 120f931)

Co-authored-by: Marius Iversen <[email protected]>
leehinman pushed a commit to leehinman/beats that referenced this pull request Nov 3, 2020
…and for date checking when eventtime is missing (elastic#22361)

* fixing assignip and making sure it does not error on missing eventtime field

* updating changelog

(cherry picked from commit 120f931)
leehinman added a commit that referenced this pull request Nov 3, 2020
…and for date checking when eventtime is missing (#22361) (#22364)

* fixing assignip and making sure it does not error on missing eventtime field

* updating changelog

(cherry picked from commit 120f931)

Co-authored-by: Marius Iversen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants