Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22845 to 7.x: Duplicate fields from system.process to process.* #22945

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Cherry-pick #22845 to 7.x: Duplicate fields from system.process to process.* #22945

merged 1 commit into from
Dec 7, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 5, 2020

Cherry-pick of PR #22845 to 7.x branch. Original message:

What does this PR do?

This PR is to rename several fields from system.process metricset to process.*. Here is the full list:

  • system.process.state -> process.state
  • system.process.cpu.total.norm.pct -> process.cpu.pct
  • system.process.cpu.start_time -> process.cpu.start_time
  • system.process.memory.rss.pct -> process.memory.pct

cc @fearful-symmetry @mukeshelastic

Why is it important?

This is a part of the inventory schema work for process. Please see #22216 for more details.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Dec 5, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 5, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22945 opened

  • Start Time: 2020-12-05T01:16:41.737+0000

  • Duration: 65 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 2319
Skipped 521
Total 2840

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2319
Skipped 521
Total 2840

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@kaiyan-sheng kaiyan-sheng merged commit 24f8f3c into elastic:7.x Dec 7, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22845_7.x branch December 7, 2020 15:10
@zube zube bot removed the [zube]: Done label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants