Update filestream reader offset when line is skipped #23417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
urso
approved these changes
Jan 21, 2021
kvch
force-pushed
the
fix-filebeat-update-filestream-offset-when-needed
branch
from
fc8d50f
to
7176c36
Compare
2 tasks
kvch
added
v7.12.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jan 21, 2021
This PR adds two previously missing offset updates to the `filestream` reader when a line is skipped. The offset could be incorrect if Filebeat skips the line if the line should not be published because of user configuration in `export_line` or `import_line` If the offset is not updated in the reader, the state information of newer published events become incorrect. This might lead to duplicated events if Filebeat is restarted. (cherry picked from commit e5cd64f)
kvch
added a commit
that referenced
this pull request
Jan 21, 2021
This PR adds two previously missing offset updates to the `filestream` reader when a line is skipped. The offset could be incorrect if Filebeat skips the line if the line should not be published because of user configuration in `export_line` or `import_line` If the offset is not updated in the reader, the state information of newer published events become incorrect. This might lead to duplicated events if Filebeat is restarted. (cherry picked from commit e5cd64f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds two previously missing offset updates to the
filestreamreader when a line is skipped.Why is it important?
The offset could be incorrect if Filebeat skips the line for the following reasons:
export_lineorimport_lineIf the offset is not updated in the reader, the state information of newer published events become incorrect. This might lead to duplicated events if Filebeat is restarted.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Reading this file
Validate that Filebeat does not send duplicate messages.