Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Elastic Agent - Endpoint e2e test fix #23776

Merged

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Feb 1, 2021

What does this PR do?

This PR uses CN together with DNSName,
in nightly test we see that when agent is assigned an Endpoint Security integration it wont show up in Security App.
I was not able to get more info from Endpoint so far but what i see is a message AgentComms.cpp:628 Waiting for GRPC connection to be READY for. really long period of time.

Agent wise we are not experiencing any errors,
Creds endpoint created a LISTENING
I see endpoint connecting to Creds endpoint and not issues there server side.

But when i change generated cert to have CN as addition to DNSNames, endpoint is ready in 20s and Endpoint reported green, showing up in security tabs. I did multiple runs, mutiple build always same behavior.
I suspect gdpr library to do some checks on CN so while golang stopped supporting CN and we moved to DNSNames we probably need to keep CN for a while

Why is it important?

#23693

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 1, 2021
@michalpristas
Copy link
Contributor Author

/Package

@michalpristas michalpristas changed the title fix [Ingest Manager] Elastic Agent - Endpoint e2e test fix Feb 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23776 opened

    • Start Time: 2021-02-01T12:25:08.265+0000
  • Duration: 28 min 43 sec

  • Commit: 3514ff7

Test stats 🧪

Test Results
Failed 0
Passed 5846
Skipped 16
Total 5862

Steps errors 1

Expand to view the steps failures

x-pack/elastic-agent-windows-2016-windows-2016 - Install Go/Mage/Python 1.15.7
  • Took 0 min 10 sec . View more details on here
  • Description: .ci/scripts/install-tools.bat

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5846
Skipped 16
Total 5862

@ph
Copy link
Contributor

ph commented Feb 1, 2021

@michalpristas Can you clarify the description of this PR, is that working at intended? is there a bug with endpoint?

@blakerouse
Copy link
Contributor

This must have to do with the switch to go 1.15. Some reason the certificate generation changes that cause endpoint to stop connecting. I would be surprised this was a change on the Endpoint side.

@michalpristas
Copy link
Contributor Author

@ph i think it's something related to gdpr library, they use one from google. i was asking in a channel but so far no response about how to gather details or anything helpful endpoint side.

@michalpristas
Copy link
Contributor Author

/Packaging

@ph
Copy link
Contributor

ph commented Feb 1, 2021

Thanks @michalpristas for the clarification, I think @blakerouse is right here concerning the 1.15 changes.

@v1v
Copy link
Member

v1v commented Feb 1, 2021

/packaging

1 similar comment
@mdelapenya
Copy link
Contributor

/packaging

@michalpristas michalpristas merged commit 333edd8 into elastic:master Feb 1, 2021
@mdelapenya
Copy link
Contributor

Good catch!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants