Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix Zoom module config for url and basic auth #23779

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

andrewkroh
Copy link
Member

What does this PR do?

The basic auth username and password options were broken. And the url parameter was
missing from the config despite being defined in the manifest.

Why is it important?

The option to host the webhook callback as a prefix other than / is not possible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh andrewkroh added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 1, 2021
The basic auth username and password options were broken. And the `url` parameter was
missing from the config despite being defined in the manifest.
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23779 opened

    • Start Time: 2021-02-01T13:09:20.861+0000
  • Duration: 43 min 4 sec

  • Commit: 3593cc8

Test stats 🧪

Test Results
Failed 0
Passed 6786
Skipped 1049
Total 7835

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6786
Skipped 1049
Total 7835

@andrewkroh andrewkroh merged commit a974f4f into elastic:master Feb 1, 2021
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Feb 1, 2021
The basic auth username and password options were broken. And the `url` parameter was
missing from the config despite being defined in the manifest.

(cherry picked from commit a974f4f)
@andrewkroh andrewkroh added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 1, 2021
andrewkroh added a commit that referenced this pull request Feb 1, 2021
The basic auth username and password options were broken. And the `url` parameter was
missing from the config despite being defined in the manifest.

(cherry picked from commit a974f4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants