Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] httpjson split strings on delimiter #24022

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds a new split type to httpjson input, so you can split on strings
inside the response body.

  • adds new split type "string"
  • adds new split config option "delimiter", to specify what to split on

Why is it important?

Necessary if a string field contains information that should be spit
into multiple events

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

mage goUnitTest

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 11, 2021
@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Feb 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 11, 2021
- adds new split type "string"
- adds new split config option "delimiter"
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24022 updated

  • Start Time: 2021-02-12T16:18:29.526+0000

  • Duration: 50 min 35 sec

  • Commit: 590f1e0

Test stats 🧪

Test Results
Failed 0
Passed 6830
Skipped 1049
Total 7879

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6830
Skipped 1049
Total 7879

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good from my POV, but @marc-gr should probably take a look.

x-pack/filebeat/docs/inputs/input-httpjson.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leehinman leehinman merged commit 5414972 into elastic:master Feb 12, 2021
@leehinman leehinman added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 12, 2021
leehinman added a commit to leehinman/beats that referenced this pull request Feb 12, 2021
* [Filebeat] httpjson split strings on delimiter

- adds new split type "string"
- adds new split config option "delimiter"

(cherry picked from commit 5414972)
@leehinman leehinman deleted the httpjson_delimiter_split branch February 12, 2021 19:34
leehinman added a commit that referenced this pull request Feb 15, 2021
* [Filebeat] httpjson split strings on delimiter

- adds new split type "string"
- adds new split config option "delimiter"

(cherry picked from commit 5414972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants