Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24019 to 7.12: Update dependencies for M1 support in System #24335

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Mar 3, 2021

This PR (I think) got merged riiiight after 7.12 was branched. Whoops.
Cherry-pick of PR #24019 to 7.12 branch. Original message:

What does this PR do?

This is the result of updating go-sysinfo and gosigar and running go mod tidy. I'm still in the process of testing Metricbeat as a whole against M1, and some holes in the test tooling aren't helping, so I'm just putting in this PR now.

Why is it important?

The updates in the upstream system package are needed for M1 Mac support.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR
  • Build metricbeat for darwin/arm
  • Make sure it builds.

Related issues

* update dependencies for M1 support

* add changelog entry

* make notice

* notice

(cherry picked from commit d0d1abc)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@fearful-symmetry fearful-symmetry requested a review from a team March 3, 2021 23:33
@fearful-symmetry fearful-symmetry self-assigned this Mar 3, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 3, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24335 updated

  • Start Time: 2021-03-04T17:19:01.921+0000

  • Duration: 121 min 57 sec

  • Commit: 00d015f

Test stats 🧪

Test Results
Failed 0
Passed 46002
Skipped 4973
Total 50975

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46002
Skipped 4973
Total 50975

@fearful-symmetry fearful-symmetry merged commit cec4474 into elastic:7.12 Mar 4, 2021
@zube zube bot removed the [zube]: Done label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants