Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Restructure content for SSL settings #24342

Merged
merged 4 commits into from
Mar 11, 2021
Merged

[DOCS] Restructure content for SSL settings #24342

merged 4 commits into from
Mar 11, 2021

Conversation

EamonnTP
Copy link

@EamonnTP EamonnTP commented Mar 4, 2021 •
edited
Loading

@EamonnTP EamonnTP added docs Team:Integrations Label for the Integrations team v7.11.0 v7.12.0 labels Mar 4, 2021
@EamonnTP EamonnTP requested review from urso and a team March 4, 2021 09:45
@EamonnTP EamonnTP self-assigned this Mar 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 4, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24342 updated

  • Start Time: 2021-03-10T09:37:26.345+0000

  • Duration: 21 min 33 sec

  • Commit: 04ed904

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

urso
urso reviewed Mar 4, 2021
View reviewed changes
libbeat/docs/shared-ssl-config.asciidoc
| RSA-AES-128-GCM-SHA256 | TLS 1.2 only.
| RSA-AES-256-CBC-SHA |
| RSA-AES-256-GCM-SHA384 | TLS 1.2 only.
| RSA-RC4-128-SHA | Disabled by default. RC4 not recommended.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvch @faec I'm afraid we need to clean up the list a little (in code and documentation)

@EamonnTP
Copy link
Author

EamonnTP commented Mar 8, 2021

@urso Many thanks for your review! I have updated the content.

@EamonnTP
Copy link
Author

EamonnTP commented Mar 9, 2021

@bmorelli25 Thanks for the review!

@EamonnTP EamonnTP merged commit b4ac0ee into elastic:master Mar 11, 2021
@EamonnTP EamonnTP deleted the update-ssl-content branch March 11, 2021 09:11
@EamonnTP EamonnTP mentioned this pull request Mar 11, 2021
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (elastic#24342)
aa40c85 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
@EamonnTP EamonnTP mentioned this pull request Mar 11, 2021
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (elastic#24342)
796a233 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
@EamonnTP EamonnTP mentioned this pull request Mar 11, 2021
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (elastic#24342)
c6ed4b8 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
# Conflicts:
#	libbeat/docs/shared-ssl-config.asciidoc
EamonnTP pushed a commit that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (#24342) (#24492)
e7e2d47 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
EamonnTP pushed a commit that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (#24342) (#24493)
f5caf03 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
EamonnTP pushed a commit that referenced this pull request Mar 11, 2021
[DOCS] Restructure content for SSL settings (#24342) (#24494)
e627ebd 
* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
# Conflicts:
#	libbeat/docs/shared-ssl-config.asciidoc
v1v added a commit to v1v/beats that referenced this pull request Mar 16, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/ci-flaky-…
10a34a5 
…reporting-changes

* upstream/master: (23 commits)
  [Auditbeat] btmp offset check (elastic#24515)
  Clarify that the Tomcat module is for ingesting access logs (elastic#24543)
  [Ingest Manager] Move logging defaults to agent (elastic#24535)
  Update input-http-endpoint.asciidoc (elastic#24490)
  Fix typo in mqtt input docs (elastic#24509)
  [Elastic Agent] Add verification check when updating communication to Kibana. (elastic#24489)
  Refactor use of system.hostfs to fix cgroup metrics (elastic#24334)
  Add test for close.reader.after_interval to filestream input (elastic#24423)
  chore(ci): use beat_version instead of PR version (elastic#24446)
  Add syntax for multiple selector logging (elastic#24207) (elastic#24497)
  Update Golang to 1.15.9 (elastic#24442)
  [Elastic Agent] Add the ability to provide custom CA's inside of docker. (elastic#24486)
  Add tests for encoding settings of filestream input (elastic#24426)
  [Ingest Manager] Sync on rename on windows (elastic#24504)
  Port four Harvester tests of log input to filestream in Golang (elastic#24250)
  [DOCS] Restructure content for SSL settings (elastic#24342)
  Move example to the correct location in reference docs (elastic#24455)
  Add unit tests for harvester.go of input-logfile package (elastic#24107)
  Fix type for uwsgi.status.worker.rss field (elastic#24468)
  [Ingest Manager] Logging to file disabled on enroll (elastic#24466)
  ...
@bmorelli25 bmorelli25 mentioned this pull request Apr 28, 2021
Merged
3 tasks
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
[DOCS] Restructure content for SSL settings (elastic#24342) (elastic#…
59c4582 
…24493)

* Reorg ssl content

* Edits following review

* Review edits

* Updates following review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@urso urso urso approved these changes

Assignees

@EamonnTP EamonnTP

Labels
docs Team:Integrations Label for the Integrations team v7.11.0 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs for SSL settings are somewhat confusing
4 participants
@EamonnTP @elasticmachine @urso @bmorelli25