Cherry-pick #24190 to 7.x: Port two Harvester tests of log input to filestream in Golang #24604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#24190) This PR ports the following Python tests of the `log` input to `filestream` to Golang: - `test_harvester.py:test_close_renamed` - `test_harvester.py:test_close_eof` The checks no longer rely on messages on Filebeat logs. Increased the test coverage of `filestream`: File | Before | After ----- | ----- | ----- `filebeat/input/filestream/input.go` | 0% | 57.4% `filebeat/input/filestream/prospector.go` | 86.2% | 90.0% `filebeat/input/filestream/filestream.go` | 67.1% | 79.1% `filebeat/input/filestream/fswatch.go` | 51.9% | 74.8% (cherry picked from commit c3b5a17)
kvch
added
[zube]: In Review
backport
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
michalpristas
approved these changes
Mar 17, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
jenkins run tests |
1 similar comment
|
jenkins run tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24190 to 7.x branch. Original message:
What does this PR do?
This PR ports the following Python tests of the
loginput tofilestreamto Golang:test_harvester.py:test_close_renamedtest_harvester.py:test_close_eofThe checks no longer rely on messages on Filebeat logs.
Why is it important?
Increased the test coverage of
filestream:filebeat/input/filestream/input.gofilebeat/input/filestream/prospector.gofilebeat/input/filestream/filestream.gofilebeat/input/filestream/fswatch.goChecklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.