Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metric beat] Fix the annotation's irregular and typo on prometheus module. #25726

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[metric beat] Fix the annotation's irregular and typo on prometheus module. #25726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metricbeat/module/prometheus/collector/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ type PromEventsGenerator interface {
// Start must be called before using the generator
Start()

// converts a Prometheus metric family into a list of PromEvents
// GeneratePromEvents converts a Prometheus metric family into a list of PromEvents
GeneratePromEvents(mf *dto.MetricFamily) []PromEvent

// Stop must be called when the generator won't be used anymore
Stop()
}

// PromEventsGeneratorFactory creates a PromEventsGenerator when instanciating a metricset
// PromEventsGeneratorFactory creates a PromEventsGenerator when instantiating a MetricSet
type PromEventsGeneratorFactory func(ms mb.BaseMetricSet) (PromEventsGenerator, error)

// MetricSet for fetching prometheus data
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/prometheus/collector/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type promEventGenerator struct{}
func (p *promEventGenerator) Start() {}
func (p *promEventGenerator) Stop() {}

// DefaultPromEventsGenerator stores all Prometheus metrics using
// GeneratePromEvents DefaultPromEventsGenerator stores all Prometheus metrics using
// only double field type in Elasticsearch.
func (p *promEventGenerator) GeneratePromEvents(mf *dto.MetricFamily) []PromEvent {
var events []PromEvent
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/prometheus/query/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ type instantVectorResult struct {
Vector []interface{} `json:"value"`
}

// InstantVectorResponse is for "vector" type from Prometheus Query API Request
// RangeVectorResponse is for "vector" type from Prometheus Query API Request
// rangeVectorResult format:
// [
// {
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/prometheus/remote_write/remote_write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type RemoteWriteEventsGenerator interface {
// Start must be called before using the generator
Start()

// converts Prometheus Samples to a map of mb.Event
// GenerateEvents converts Prometheus Samples to a map of mb.Event
GenerateEvents(metrics model.Samples) map[string]mb.Event

// Stop must be called when the generator won't be used anymore
Expand Down