Send float fields as float values to Elasticsearch #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
added
in progress
|
I suggest we backport this to 5.0 as soon as the tests pass as I don't think this is a breaking change. As we discussed it does not prevent people from still loading the dashboard, but it is a nice fallback. |
monicasarbu
force-pushed
the
autodetect_float_values
branch
from
49539f9
to
5b0b8c2
Compare
…g the mapping in advance
monicasarbu
force-pushed
the
autodetect_float_values
branch
from
d4e4b08
to
38e7fae
Compare
ruflin
reviewed
Oct 4, 2016
| @@ -134,7 +134,7 @@ def test_dropevent_with_complex_condition(self): | |||
| output = self.read_output( | |||
| required_fields=["@timestamp", "type"], | |||
| ) | |||
| assert len(output) == 1 | |||
| assert len(output) >= 1 | |||
There was a problem hiding this comment.
Is this change somehow related to the changes above or just a flaky test?
There was a problem hiding this comment.
flaky test, as it's variable how many events are sent out.
|
LGTM |
monicasarbu
added a commit
to monicasarbu/beats
that referenced
this pull request
Oct 5, 2016
…g the mapping in advance (elastic#2627)
This was referenced Oct 5, 2016
monicasarbu
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…g the mapping in advance (elastic#2627) (elastic#2687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to remove the necessity to define the mapping before inserting the data into Elasticsearch, by making sure that float fields are always sent as float values even if they are not flows. For example
5will be sent as5.00000, so Elasticsearch defines it asfloat.With this change, it's not needed to load the template in advance, before inserting the data into Elasticsearch.
NOTE: This also affects processors.