Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #26479 to 7.x: [metricbeat] Add state_job metricset #26670

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jul 1, 2021

Cherry-pick of PR #26479 to 7.x branch. Original message:

Add a Metricbeat metricset for Kubernetes Job resources.

What does this PR do?

Adds a state_job metricset to the Metricbeat Kubernetes module. Follows the established pattern of consuming Kube State Metrics output.

Why is it important?

Enables monitoring and alerting for Kubernetes Jobs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Run unit tests
$ MODULE=kubernetes mage -v test
  1. Deploy Metricbeat and enable this metricset. Verify that metrics about Jobs are being collected as expected along with k8s metadata.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: ChrsMark commented: /test

  • Start Time: 2021-07-02T07:47:24.207+0000

  • Duration: 106 min 12 sec

  • Commit: ddc6c5f

Test stats 🧪

Test Results
Failed 0
Passed 31577
Skipped 3946
Total 35523

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 31577
Skipped 3946
Total 35523

@ChrsMark
Copy link
Member Author

ChrsMark commented Jul 2, 2021

/test

@ChrsMark ChrsMark merged commit 61c89f8 into elastic:7.x Jul 5, 2021
@zube zube bot removed the [zube]: Done label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants