-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[httpjson] Add value_type parameter to httpjson transforms #26847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 12, 2021
marc-gr
force-pushed
the
feat-httpjson-value_type
branch
from
July 12, 2021 16:19
77e3810
to
07a0aeb
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 12, 2021
P1llus
approved these changes
Jul 12, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
force-pushed
the
feat-httpjson-value_type
branch
from
July 13, 2021 06:59
07a0aeb
to
565a33b
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
* [httpjson] Add new tpl functions * [httpjson] Change last_response.page internal type to int64 * [httpjson] Add new value_type parameter * Add changelog entry * Add new value type to tests (cherry picked from commit 0b1736e)
marc-gr
added a commit
that referenced
this pull request
Jul 13, 2021
…26856) * [httpjson] Add new tpl functions * [httpjson] Change last_response.page internal type to int64 * [httpjson] Add new value_type parameter * Add changelog entry * Add new value type to tests (cherry picked from commit 0b1736e) Co-authored-by: Marc Guasch <[email protected]>
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jul 19, 2021
* master: (61 commits) Add disk queue unit tests based on the queuetest package [Heartbeat] redact authorization headers from logger (elastic#26892) Expose custom process metrics (elastic#26912) [gcp/billing] always quote table name identifier (elastic#26870) Add Beats central management removal to BCs (elastic#26400) Add custom suffix to identifiers in filestream input when needed (elastic#26669) Update asa-ftd-pipeline.yml (elastic#26265) Use common host parser in vsphere module (elastic#26904) [automation] Update go release version 1.16.6 (elastic#26860) Skip flaky test: filestream and harvester group (elastic#26728) [Filebeat] Remove alias fields from Suricata and Traefik module mappings (elastic#26627) docs: apm-server.auth (elastic#26831) [Automation] Update elastic stack version to 8.0.0-2f008f4a for testing (elastic#26881) Clarify the scope of start/end multiline example (elastic#26786) [Heartbeat]: update Node.js version for synthetics (elastic#26867) [fix][httpjson] Fix incorrect key for template data (elastic#26848) [httpjson] Add value_type parameter to httpjson transforms (elastic#26847) [Heartbeat]: capture error from journey/end events (elastic#26781) [Winlogbeat] Fixes for wineventlog experimental api (elastic#26826) Set agent.id to Fleet Agent ID for each metric/log monitoring input (elastic#26776) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
value_type
parameter to the transforms.Adds
mul
anddiv
template functions.Modifies
toInt
to accept more types other thanstring
Why is it important?
This allows to use the output from the
value
templates as other value types different than string. Initiallyint
andjson
types have been added, allowing to define the output of the templates to be used as integer literals eg0
vs"0"
or JSON objects{"foo":"bar"}
or["foo","bar"}
vs"{\"foo\":\"bar\"}"
or"[\"foo\":\"bar\"]"
.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.