feat: add huaweicloud metadata support. #27607

Colstuwjx · 2021-08-26T11:00:58Z

Signed-off-by: colstuwjx [email protected]

Enhancement

What does this PR do?

This PR is going to add Huawei cloud metadata provider support.

Why is it important?

There are lots of company are using huaweicloud ecs, and this PR will help them collect ECS level metadata.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

cla-checker-service · 2021-08-26T11:01:03Z

💚 CLA has been signed

elasticmachine · 2021-08-26T11:05:59Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-09-20T11:14:17.722+0000
Duration: 144 min 58 sec
Commit: 5915055

Test stats 🧪

Test	Results
Failed	0
Passed	54044
Skipped	5327
Total	59371

Trends 🧪

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	54044
Skipped	5327
Total	59371

Colstuwjx · 2021-08-27T01:37:01Z

I signed it!

elasticmachine · 2021-09-13T16:35:33Z

Pinging @elastic/integrations (Team:Integrations)

jsoriano · 2021-09-13T16:35:47Z

/test

jsoriano

Hey @Colstuwjx,

Thanks for your contribution! Code-wise it looks good to me, but could you please add a changelog entry in CHANGELOG.next.asciidoc?

@kaiyan-sheng could you please also have a second look?

kaiyan-sheng · 2021-09-13T18:35:19Z

Code looks good to me too. One question, @jsoriano should Huawei be enabled by default? I remember we have to disable Alibaba Cloud and Tencent cloud providers because they require to access a remote host.

jsoriano · 2021-09-14T07:30:25Z

should Huawei be enabled by default? I remember we have to disable Alibaba Cloud and Tencent cloud providers because they require to access a remote host.

This provider gets the data from 169.254.169.254, as for AWS, Azure or GCP, so I guess that it can be enabled by default.

libbeat/processors/add_cloud_metadata/provider_huawei_cloud.go

mergify · 2021-09-14T07:36:57Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b huaweicloud-metadata upstream/huaweicloud-metadata
git merge upstream/master
git push upstream huaweicloud-metadata

jsoriano · 2021-09-14T07:38:51Z

could you please add a changelog entry in CHANGELOG.next.asciidoc?

I have added it, this would be ready to merge.

Signed-off-by: colstuwjx <[email protected]>

Colstuwjx · 2021-09-14T10:42:55Z

Code looks good to me too. One question, @jsoriano should Huawei be enabled by default? I remember we have to disable Alibaba Cloud and Tencent cloud providers because they require to access a remote host.

HuaweiCloud is similar to openstack, it's using 169.254.169.254, which should be local call, so I think it's ok to enable by default.

I've been rebased with master! Now I think it's ready to merge!

Colstuwjx · 2021-09-14T10:48:37Z

Fixed a rebase issue, the PR commits are clear right now.

jsoriano · 2021-09-14T10:49:14Z

/test

mergify · 2021-09-19T22:26:24Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b huaweicloud-metadata upstream/huaweicloud-metadata
git merge upstream/master
git push upstream huaweicloud-metadata

Colstuwjx · 2021-09-22T02:17:30Z

@jsoriano @kaiyan-sheng Anything updates? If there is any issue left, please let me know.

kaiyan-sheng

Looks good to me.

Signed-off-by: colstuwjx <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> (cherry picked from commit 86004dd)

* feat: add huaweicloud metadata support. (#27607) Signed-off-by: colstuwjx <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> (cherry picked from commit 86004dd) * Update CHANGELOG.next.asciidoc Co-authored-by: Jacky Wu <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]>

Signed-off-by: colstuwjx <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>

* Remove huaweicloud - revert #27607 The huaweicloud is just openstack therefore revert #27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]>

* Remove huaweicloud - revert #27607 The huaweicloud is just openstack therefore revert #27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]> (cherry picked from commit 07c559b) # Conflicts: # libbeat/processors/add_cloud_metadata/docs/add_cloud_metadata.asciidoc # libbeat/processors/add_cloud_metadata/provider_huawei_cloud.go # libbeat/processors/add_cloud_metadata/provider_huawei_cloud_test.go # libbeat/processors/add_cloud_metadata/providers.go

* Remove huaweicloud - revert #27607 The huaweicloud is just openstack therefore revert #27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]> (cherry picked from commit 07c559b)

* Remove huaweicloud - revert #27607 (#35184) * Remove huaweicloud - revert #27607 The huaweicloud is just openstack therefore revert #27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]> (cherry picked from commit 07c559b) * Update CHANGELOG.next.asciidoc * fix footnote --------- Co-authored-by: Maximilian Stinsky <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]>

* Remove huaweicloud - revert #27607 (#35184) * Remove huaweicloud - revert #27607 The huaweicloud is just openstack therefore revert #27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]> (cherry picked from commit 07c559b) # Conflicts: # libbeat/processors/add_cloud_metadata/docs/add_cloud_metadata.asciidoc # libbeat/processors/add_cloud_metadata/provider_huawei_cloud.go # libbeat/processors/add_cloud_metadata/provider_huawei_cloud_test.go # libbeat/processors/add_cloud_metadata/providers.go * Update CHANGELOG.next.asciidoc * Update add_cloud_metadata.asciidoc * Update providers.go * fix doc * fix lint --------- Co-authored-by: Maximilian Stinsky <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]>

* Remove huaweicloud - revert elastic#27607 The huaweicloud is just openstack therefore revert elastic#27607 to fix detection of all public and private openstack installations. * make huawei an alias for openstack * change doc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: kaiyan-sheng <[email protected]>

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2021

jsoriano added the Team:Integrations Label for the Integrations team label Sep 13, 2021

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2021

jsoriano reviewed Sep 13, 2021

View reviewed changes

jsoriano approved these changes Sep 14, 2021

View reviewed changes

libbeat/processors/add_cloud_metadata/provider_huawei_cloud.go Outdated Show resolved Hide resolved

jsoriano added the backport-v7.16.0 Automated backport with mergify label Sep 14, 2021

Colstuwjx and others added 2 commits September 14, 2021 18:35

feat: add huaweicloud metadata support.

2bf1eea

Signed-off-by: colstuwjx <[email protected]>

Update CHANGELOG.next.asciidoc

9159880

fix: correct meta host var name.

a3f2809

Colstuwjx force-pushed the huaweicloud-metadata branch from 454419e to a3f2809 Compare September 14, 2021 10:47

jsoriano approved these changes Sep 14, 2021

View reviewed changes

Merge branch 'master' into huaweicloud-metadata

5915055

kaiyan-sheng approved these changes Sep 22, 2021

View reviewed changes

kaiyan-sheng merged commit 86004dd into elastic:master Sep 22, 2021

mergify bot pushed a commit that referenced this pull request Sep 22, 2021

feat: add huaweicloud metadata support. (#27607)

06167cb

Signed-off-by: colstuwjx <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> (cherry picked from commit 86004dd)

mergify bot mentioned this pull request Sep 22, 2021

[7.x](backport #27607) feat: add huaweicloud metadata support. #28037

Merged

Colstuwjx deleted the huaweicloud-metadata branch September 22, 2021 03:06

Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021

feat: add huaweicloud metadata support. (elastic#27607)

3bf0875

Signed-off-by: colstuwjx <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>

kesslerm mentioned this pull request Mar 28, 2022

Wrong detection of cloud.provider since Beats 8.0 (openstack as huawei) #31022

Closed

mstinsky mentioned this pull request Apr 24, 2023

Remove huaweicloud - revert #27607 #35184

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add huaweicloud metadata support. #27607

feat: add huaweicloud metadata support. #27607

Colstuwjx commented Aug 26, 2021 •

edited

Loading

cla-checker-service bot commented Aug 26, 2021 •

edited

Loading

elasticmachine commented Aug 26, 2021 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

Trends 🧪

Test stats 🧪

Colstuwjx commented Aug 27, 2021

elasticmachine commented Sep 13, 2021

jsoriano commented Sep 13, 2021

jsoriano left a comment

kaiyan-sheng commented Sep 13, 2021

jsoriano commented Sep 14, 2021

mergify bot commented Sep 14, 2021

jsoriano commented Sep 14, 2021

Colstuwjx commented Sep 14, 2021

Colstuwjx commented Sep 14, 2021

jsoriano commented Sep 14, 2021

mergify bot commented Sep 19, 2021

Colstuwjx commented Sep 22, 2021

kaiyan-sheng left a comment

feat: add huaweicloud metadata support. #27607

feat: add huaweicloud metadata support. #27607

Conversation

Colstuwjx commented Aug 26, 2021 • edited Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

cla-checker-service bot commented Aug 26, 2021 • edited Loading

elasticmachine commented Aug 26, 2021 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

💚 Flaky test report

Test stats 🧪

Colstuwjx commented Aug 27, 2021

elasticmachine commented Sep 13, 2021

jsoriano commented Sep 13, 2021

jsoriano left a comment

Choose a reason for hiding this comment

kaiyan-sheng commented Sep 13, 2021

jsoriano commented Sep 14, 2021

mergify bot commented Sep 14, 2021

jsoriano commented Sep 14, 2021

Colstuwjx commented Sep 14, 2021

Colstuwjx commented Sep 14, 2021

jsoriano commented Sep 14, 2021

mergify bot commented Sep 19, 2021

Colstuwjx commented Sep 22, 2021

kaiyan-sheng left a comment

Choose a reason for hiding this comment

Colstuwjx commented Aug 26, 2021 •

edited

Loading

cla-checker-service bot commented Aug 26, 2021 •

edited

Loading

elasticmachine commented Aug 26, 2021 •

edited by jenkins-beats-ci bot

Loading