Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/undocumented IncludeCreatorMetadata setting #28006

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR removes IncludeCreaterMetadata setting from kubernetes metadata configuration, since it was undocumented and marked for deprecation.

Why is it important?

This is an undocumented/deprecated setting. Removing this so as to clean up the configuration options.

This change is targeting v8.0.0

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2021
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark self-assigned this Sep 20, 2021
@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Sep 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2021
@ChrsMark ChrsMark added the backport-v8.0.0 Automated backport with mergify label Sep 20, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-21T07:57:02.522+0000

  • Duration: 153 min 5 sec

  • Commit: 515d637

Test stats 🧪

Test Results
Failed 0
Passed 54042
Skipped 5327
Total 59369

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 54042
Skipped 5327
Total 59369

@ChrsMark ChrsMark changed the title Remove deprecated/undocumented IncludeCreaterMetadata setting Remove deprecated/undocumented IncludeCreatorMetadata setting Sep 21, 2021
Signed-off-by: chrismark <[email protected]>
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants