Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated fields from k8s module #28046

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Remove deprecated fields from k8s module #28046

merged 3 commits into from
Sep 23, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Sep 22, 2021 •
edited
Loading

What does this PR do?

This PR removes deprecated fields from Kubernetes module.

Removing:
kubernetes.container.cpu.limit.nanocores
kubernetes.container.cpu.request.nanocores

Why is it important?

Part of #11835

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Sep 22, 2021
@ChrsMark ChrsMark self-assigned this Sep 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 22, 2021
@botelastic
Copy link

botelastic bot commented Sep 22, 2021

This pull request doesn't have a Team:<team> label.

@ChrsMark ChrsMark mentioned this pull request Sep 22, 2021
Closed
5 tasks
@ChrsMark ChrsMark added backport-v8.0.0 Automated backport with mergify v8.0.0 breaking change release-note:breaking The content should be included as a breaking change labels Sep 22, 2021
@ChrsMark
Add changelog
858f991 
Signed-off-by: chrismark <[email protected]>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 22, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-22T14:16:03.652+0000

  • Duration: 88 min 1 sec

  • Commit: ad9d309

Test stats 🧪

Test Results
Failed 0
Passed 9134
Skipped 2412
Total 11546

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9134
Skipped 2412
Total 11546

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test

  • jenkins run the tests

MichaelKatsoulis
MichaelKatsoulis approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrsMark
Copy link
Member Author

/test

@ChrsMark ChrsMark merged commit dfb0b27 into elastic:master Sep 23, 2021
mergify bot pushed a commit that referenced this pull request Sep 23, 2021
@ChrsMark
Remove deprecated fields from k8s module (#28046)
4ec7dee 
(cherry picked from commit dfb0b27)
@mergify mergify bot mentioned this pull request Sep 23, 2021
Closed
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@ChrsMark
Remove deprecated fields from k8s module (elastic#28046)
523e4dd
@tetianakravchenko tetianakravchenko mentioned this pull request Apr 29, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

Assignees

@ChrsMark ChrsMark

Labels
backport-v8.0.0 Automated backport with mergify breaking change release-note:breaking The content should be included as a breaking change Team:Integrations Label for the Integrations team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @MichaelKatsoulis