Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup to remove uneeded 8.0 comment from GenerateK8s metadata #28781

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Fixup to remove uneeded 8.0 comment from GenerateK8s metadata #28781

merged 1 commit into from
Nov 3, 2021

Conversation

MichaelKatsoulis
Copy link
Contributor

This PR removes a not needed comment from libbeat GenerateK8s method which enriches an event with kubernetes metadata

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

This pull request does not have a backport label. Could you fix it @MichaelKatsoulis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 3, 2021
@MichaelKatsoulis MichaelKatsoulis added the Team:Integrations Label for the Integrations team label Nov 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2021
ChrsMark
ChrsMark approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-03T09:25:14.979+0000

  • Duration: 137 min 14 sec

  • Commit: 2c0cf4e

Test stats 🧪

Test Results
Failed 0
Passed 54119
Skipped 5355
Total 59474

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@MichaelKatsoulis MichaelKatsoulis added the backport-v8.0.0 Automated backport with mergify label Nov 3, 2021
@MichaelKatsoulis MichaelKatsoulis merged commit d504254 into elastic:master Nov 3, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 3, 2021
mergify bot pushed a commit that referenced this pull request Nov 3, 2021
@MichaelKatsoulis
Fixup to remove uneeded 8.0 comment from GenerateK8s metadata (#28781)
be0e0f1 
(cherry picked from commit d504254)
@mergify mergify bot mentioned this pull request Nov 3, 2021
Merged
MichaelKatsoulis added a commit that referenced this pull request Nov 22, 2021
@mergify @MichaelKatsoulis
Fixup to remove uneeded 8.0 comment from GenerateK8s metadata (#28781) (
c2c4a91 
#28785)

(cherry picked from commit d504254)

Co-authored-by: Michael Katsoulis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
backport-v8.0.0 Automated backport with mergify bug Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelKatsoulis @elasticmachine @ChrsMark