Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in aws.rds.write_iops field in processor #28960

Merged
merged 2 commits into from
Nov 15, 2021
Merged

typo in aws.rds.write_iops field in processor #28960

merged 2 commits into from
Nov 15, 2021

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Nov 15, 2021

Bug

What does this PR do?

use the proper to value aws.rds.write.iops instead of aws.rds.write_iops for rename processor in rds metricset

Why is it important?

Fields were renamed in #28350.
A typo in the rename processor for aws.rds.write.iops slipped through CR.
The processor is ingesting the data in the wrong field.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2021

This pull request does not have a backport label. Could you fix it @aspacca? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 15, 2021
@aspacca aspacca added backport-v8.0.0 Automated backport with mergify Team:Platforms Label for the Integrations - Platforms team labels Nov 15, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-15T12:16:39.663+0000

  • Duration: 79 min 8 sec

  • Commit: ef9c881

Test stats 🧪

Test Results
Failed 0
Passed 2661
Skipped 240
Total 2901

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aspacca aspacca merged commit 84ad0b3 into elastic:master Nov 15, 2021
mergify bot pushed a commit that referenced this pull request Nov 15, 2021
* typo in aws.rds.write_iops field in processor

* changelog

(cherry picked from commit 84ad0b3)
aspacca pushed a commit that referenced this pull request Nov 15, 2021
…28966)

* typo in aws.rds.write_iops field in processor (#28960)

* typo in aws.rds.write_iops field in processor

* changelog

(cherry picked from commit 84ad0b3)

* fix changelog

Co-authored-by: Andrea Spacca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants