-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbeat,packetbeat,x-pack/filebeat/input/netflow: unify gopacket dependencies #29167
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
c1de28a
to
593dd76
Compare
/test |
1 similar comment
/test |
The code was dropped from types that do not use the code field in google/gopacket pr 134.
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
This has fixes for use on older linux kernels and api for reloading WinPCAP.
E2E failure looks unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ow: unify gopacket dependencies (#29283) * libbeat,packetbeat,x-pack/filebeat/input/netflow: unify gopacket dependencies (#29167) (cherry picked from commit c3d31a4) # Conflicts: # go.sum * fix go.sum Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Dan Kortschak <[email protected]>
What does this PR do?
This unifies and updates the gopacket dependencies for network traffic analysis.
Why is it important?
Currently the project depends on three forks of the gopacket library. This complicates dependency management, and with many of the fixes now merged upstream it needlessly prevent us having access to new features of gopacket (though note the intention to make a canonical elastic/gopacket fork and elastic/gopacket#3 — hopefully in the long term merging changes back upstream.)
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
No specific checks.
How to test this PR locally
standard testing.
Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A