-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default region config to AWS #29415
Conversation
This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
NOTE: |
a90e6f2
to
82b4abd
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This pull request is now in conflicts. Could you fix it? 🙏
|
thanks @legoguy1000 for the PR only thing left is to add test coverage for the change |
Yup tracking, it's on my list for later today. |
82b4abd
to
9ca1901
Compare
Pinging @elastic/integrations (Team:Integrations) |
* Add default regon config to AWS * update changelog * Add tests (cherry picked from commit 81ed8f8) # Conflicts: # x-pack/libbeat/common/aws/credentials.go # x-pack/libbeat/common/aws/credentials_test.go # x-pack/libbeat/docs/aws-credentials-config.asciidoc
(cherry picked from commit 81ed8f8) Co-authored-by: Alex Resnick <[email protected]> Co-authored-by: Andrea Spacca <[email protected]>
Hello, |
Right now it's only in 8.0+. @aspacca is it too late to get into the next 7.x version? |
the feature will hit 8.0 |
What does this PR do?
Adds a new config to the AWS common module
deafult_region
.Why is it important?
This is to resolve issues as discussed in https://discuss.elastic.co/t/input-aws-s3-failed-with-failed-to-initialize-s3-poller/288130. Currently the module uses the us-east-1 region as the default anytime there isn't another item overriding it, like to query the location of a S3 bucket. As shown in the forum, that doesn't always work and should have a way to change the default like with the AWS CLI.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Run unit/integration tests for the AWS common module
Related issues
Use cases
Screenshots
Logs