Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System/socket: Support kernel_clone() replacement for _do_fork() #29744

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jan 7, 2022

What does this PR do?

Updates the system/socket dataset to support kernels 5.10+ where the do_fork kernel method is replaced by kernel_clone.

Why is it important?

Lack of support for this method is preventing startup in newer kernels.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2022

This pull request does not have a backport label. Could you fix it @adriansr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 7, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-07T16:36:40.093+0000

  • Duration: 68 min 21 sec

  • Commit: ec6be7f

Test stats 🧪

Test Results
Failed 0
Passed 342
Skipped 145
Total 487

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@adriansr adriansr marked this pull request as ready for review January 7, 2022 16:46
@adriansr adriansr requested a review from a team as a code owner January 7, 2022 16:46
@adriansr adriansr changed the title System/socket: Support kernel_clone() replacement for _do_fork System/socket: Support kernel_clone() replacement for _do_fork() Jan 7, 2022
@adriansr adriansr added Auditbeat backport-v7.16.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify bug review Team:Security-External Integrations labels Jan 7, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2022
@adriansr adriansr removed the backport-skip Skip notification from the automated backport with mergify label Jan 7, 2022
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adriansr adriansr merged commit 2874b62 into elastic:master Jan 8, 2022
mergify bot pushed a commit that referenced this pull request Jan 8, 2022
)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)
mergify bot pushed a commit that referenced this pull request Jan 8, 2022
)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)
mergify bot pushed a commit that referenced this pull request Jan 8, 2022
)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)
adriansr added a commit that referenced this pull request Jan 10, 2022
) (#29750)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)

Co-authored-by: Adrian Serrano <[email protected]>
adriansr added a commit that referenced this pull request Jan 10, 2022
…ment for _do_fork() (#29749)

* System/socket: Support kernel_clone() replacement for _do_fork() (#29744)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)

Co-authored-by: Adrian Serrano <[email protected]>
adriansr added a commit that referenced this pull request Jan 10, 2022
…ment for _do_fork() (#29748)

* System/socket: Support kernel_clone() replacement for _do_fork() (#29744)

Updates the system/socket dataset to support kernels 5.10+ where the _do_fork kernel function
is replaced by kernel_clone. This was preventing Auditbeat to start.

(cherry picked from commit 2874b62)

Co-authored-by: Adrian Serrano <[email protected]>
@adriansr adriansr deleted the ab_kernel_clone branch January 10, 2022 08:29
v1v added a commit to v1v/beats that referenced this pull request Jan 12, 2022
…b-for-macos

* upstream/master: (172 commits)
  [Elastic Agent] Fix issue with ensureServiceToken. (elastic#29800)
  [Winlogbeat] Add provider name to Security routing pipeline check (elastic#29781)
  Add summary to journeys which don't emit journey:end (early node subprocess exits) (elastic#29606)
  Prepare 8.0.0-rc1 changelog (elastic#29795) (elastic#29806)
  Change docker image from CentOS 7 to Ubuntu 20.04 (elastic#29681)
  libbeat/processors/add_process_metadata: implement a process cache eviction policy (elastic#29717)
  [Automation] Update elastic stack version to 8.1.0-7004acda for testing (elastic#29783)
  Missing changelog entry for elastic#29773 (elastic#29791)
  Add a readme for k8s autodiscover provider (elastic#28213)
  Remove overriding of index pattern on the Kubernetes overview dashboard (elastic#29676)
  jjbb: remove obsoleted branches (<7.16) (elastic#29707)
  Add k8s metadata in state_cronjob metricset (elastic#29572)
  ibmmq: Fix timestamp parsing (elastic#29773)
  Do not add date to index if `@meta.index` is set (elastic#29775)
  ci: uses aliases for the branches (elastic#29706)
  Filebeat tests: Restore `@timestamp` field validation (elastic#29772)
  Forward port 7.16.3 changelog to master (elastic#29777)
  auditd: Store program arguments in process.args array (elastic#29601)
  System/socket: Support kernel_clone() replacement for _do_fork() (elastic#29744)
  Do not mention removal if version is not specified in `cfgwarn` messages (elastic#29727)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-7.17 Automated backport to the 7.17 branch with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify bug review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auditbeat 7.16+ ERROR none of the required functions for DO_FORK is found.
4 participants