Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] gcp: add dataproc metricset #30008

Merged
merged 2 commits into from
Feb 10, 2022
Merged

[Metricbeat] gcp: add dataproc metricset #30008

merged 2 commits into from
Feb 10, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jan 25, 2022 •
edited
Loading

What does this PR do?

Adds dataproc metricset.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@gpop63 gpop63 added Team:Integrations Label for the Integrations team backport-v8.0.0 Automated backport with mergify labels Jan 25, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 25, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 25, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T11:44:47.286+0000

  • Duration: 110 min 6 sec

  • Commit: 86541f9

Test stats 🧪

Test Results
Failed 0
Passed 9788
Skipped 2528
Total 12316

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63
Copy link
Contributor Author

gpop63 commented Jan 26, 2022

/test

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp-dataproc-metricset upstream/gcp-dataproc-metricset
git merge upstream/master
git push upstream gcp-dataproc-metricset

@gpop63 gpop63 marked this pull request as ready for review February 3, 2022 13:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@mergify mergify bot assigned gpop63 Feb 8, 2022
endorama
endorama reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit but it looks good!

metricbeat/docs/modules_list.asciidoc
@@ -120,8 +120,9 @@ This file is generated! See scripts/mage/docs_collector.go
|<<metricbeat-metricset-etcd-self,self>>
|<<metricbeat-metricset-etcd-store,store>>
|<<metricbeat-module-gcp,Google Cloud Platform>> beta[] |image:./images/icon-yes.png[Prebuilt dashboards are available] |
.8+| .8+| |<<metricbeat-metricset-gcp-billing,billing>> beta[]
.9+| .9+| |<<metricbeat-metricset-gcp-billing,billing>> beta[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this change is related to this PR. Maybe is possible to remove it if not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be because a new metricset was added (dataproc) and the no. of lines increased by 1. The file is automatically updated by running make docs.

endorama
endorama approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge it!

@gpop63 gpop63 merged commit e61173f into elastic:main Feb 10, 2022
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@gpop63
[Metricbeat] gcp: add dataproc metricset (#30008)
f1011d6 
* Add dataproc metricset

* Update metricbeat docs

(cherry picked from commit e61173f)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	metricbeat/docs/modules/gcp.asciidoc
#	metricbeat/docs/modules_list.asciidoc
#	x-pack/metricbeat/metricbeat.reference.yml
#	x-pack/metricbeat/module/gcp/_meta/config.yml
#	x-pack/metricbeat/module/gcp/constants.go
#	x-pack/metricbeat/module/gcp/fields.go
#	x-pack/metricbeat/module/gcp/metrics/metrics_requester.go
#	x-pack/metricbeat/module/gcp/metrics/response_parser.go
#	x-pack/metricbeat/module/gcp/module.yml
#	x-pack/metricbeat/modules.d/gcp.yml.disabled
@mergify mergify bot mentioned this pull request Feb 10, 2022
Closed
@jsoriano jsoriano removed the backport-v8.0.0 Automated backport with mergify label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees

@gpop63 gpop63

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpop63 @elasticmachine @endorama @jsoriano