Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report GitHub Check before the cache #30372

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

kuisathaverat
Copy link
Contributor

When the lint stage is not reported for some reason and the CI success you can not merge the PR because the lint check is required. Due to we have a cache in place the stage is never reported as a GitHub check if there are no changes in code. By changing the order of the GitHub check, it is always returned.

@kuisathaverat kuisathaverat added ci Team:Automation Label for the Observability productivity team labels Feb 14, 2022
@kuisathaverat kuisathaverat self-assigned this Feb 14, 2022
@kuisathaverat kuisathaverat requested a review from a team as a code owner February 14, 2022 12:06
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2022

This pull request does not have a backport label. Could you fix it @kuisathaverat? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 14, 2022
@kuisathaverat kuisathaverat added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-14T15:36:03.125+0000

  • Duration: 42 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 980
Skipped 192
Total 1172

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kuisathaverat
Copy link
Contributor Author

/test

@kuisathaverat kuisathaverat merged commit f7ddf9f into elastic:main Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
…into feature/use-with-kind-k8s-env

* 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits)
  ci: home is declared within withBeatsEnv
  ci: use withKindEnv step
  ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400)
  Update fields.yml (elastic#29609)
  Heartbeat: fix browser metrics and trace mappings (elastic#30258)
  Apply light edits to 8.0 changelog (elastic#30351)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396)
  Add a ring-buffer reporter to libbeat (elastic#28750)
  Osquerybeat: Add install verification for osquerybeat (elastic#30388)
  update windows matrix support (elastic#30373)
  Refactor of metricbeat process-gathering metrics and system/process (elastic#30076)
  adjust next changelog wording (elastic#30371)
  [Metricbeat] azure: move event report into loop validDim loop (elastic#29945)
  fix: report GitHub Check before the cache (elastic#30372)
  Add support for non-unique keys in Kafka output headers (elastic#30369)
  ci: 6 major branch reached EOL (elastic#30357)
  reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650)
  [Filebeat] Add message to register encode/decode debug logs (elastic#30271)
  [libbeat] kafka message header support (elastic#29940)
  Heartbeat: set duration to zero for syntax errors (elastic#30227)
  ...
kuisathaverat added a commit that referenced this pull request Mar 7, 2022
(cherry picked from commit f7ddf9f)

Co-authored-by: Ivan Fernandez Calvo <[email protected]>
kuisathaverat added a commit that referenced this pull request Mar 7, 2022
(cherry picked from commit f7ddf9f)

Co-authored-by: Ivan Fernandez Calvo <[email protected]>
kuisathaverat added a commit that referenced this pull request Mar 14, 2022
(cherry picked from commit f7ddf9f)

Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify ci Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants