Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{,x-pack/}auditbeat: remove unused fields and params and mark platform-specific code #30490

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 21, 2022

What does this PR do?

This removes the majority of unused identified by running:

staticcheck -checks 'U*' ./{,x-pack/}auditbeat/...

Care has been taken to not remove platform-specific code and mage-required code.

This is the auditbeat part of #30483.

Why is it important?

Deadcode reduces code base maintainability.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Should be checked with the view to save deletions from the gallows. I will add lint ignore directives for chunks that are to be retained and revert those chunks.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

…m-specific code

This removes the majority of unused identified by running:

staticcheck -checks 'U*' ./{,x-pack/}auditbeat/...

Care has been taken to not remove platform-specific code and mage-required code.
@efd6 efd6 added cleanup Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.2-candidate labels Feb 21, 2022
@efd6 efd6 requested a review from andrewkroh February 21, 2022 04:14
@efd6 efd6 requested a review from a team as a code owner February 21, 2022 04:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 21, 2022
@mergify mergify bot assigned efd6 Feb 21, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-21T04:14:30.230+0000

  • Duration: 77 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 862
Skipped 162
Total 1024

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -405,6 +405,7 @@ func changeGID(t testing.TB, file string) int {

// mustRun runs a sub-test and stops the execution of the parent if the sub-test
// fails.
//lint:ignore U1000 Used in unconditionally skipped flakey tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is a comment for staticcheck. If we decide to standardize on golangci-lint then will this need to change to the //nolint:staticcheck // <comment> format?

Copy link
Contributor Author

@efd6 efd6 Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this needs discussion. It would be good if golangci-lint honoured its dependencies' linter directives (this is golangci/golangci-lint#1658). In the past the coverage of lint classes by staticcheck was quite a lot less than for the metalinters, this is less true now (vim-go defaults now to staticcheck now and gopls integrates it (currently experimentally)), so when incremental linting is possible with staticcheck I think that is would be the better option (also for the reason of the default-on .so loading that golangci-lint does). These were in my thinking when I wrote this, with the view that it could be changed down the track if an alternative decision were made.

@efd6 efd6 merged commit 670ec22 into elastic:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.2-candidate backport-skip Skip notification from the automated backport with mergify cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants