-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{,x-pack/}auditbeat: remove unused fields and params and mark platform-specific code #30490
Conversation
…m-specific code This removes the majority of unused identified by running: staticcheck -checks 'U*' ./{,x-pack/}auditbeat/... Care has been taken to not remove platform-specific code and mage-required code.
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
@@ -405,6 +405,7 @@ func changeGID(t testing.TB, file string) int { | |||
|
|||
// mustRun runs a sub-test and stops the execution of the parent if the sub-test | |||
// fails. | |||
//lint:ignore U1000 Used in unconditionally skipped flakey tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this is a comment for staticcheck
. If we decide to standardize on golangci-lint then will this need to change to the //nolint:staticcheck // <comment>
format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this needs discussion. It would be good if golangci-lint honoured its dependencies' linter directives (this is golangci/golangci-lint#1658). In the past the coverage of lint classes by staticcheck was quite a lot less than for the metalinters, this is less true now (vim-go defaults now to staticcheck now and gopls integrates it (currently experimentally)), so when incremental linting is possible with staticcheck I think that is would be the better option (also for the reason of the default-on .so loading that golangci-lint does). These were in my thinking when I wrote this, with the view that it could be changed down the track if an alternative decision were made.
What does this PR do?
This removes the majority of unused identified by running:
staticcheck -checks 'U*' ./{,x-pack/}auditbeat/...
Care has been taken to not remove platform-specific code and mage-required code.
This is the auditbeat part of #30483.
Why is it important?
Deadcode reduces code base maintainability.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs