Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch skip to use CI #30512

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Switch skip to use CI #30512

merged 1 commit into from
Feb 22, 2022

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Feb 22, 2022 •
edited
Loading

What does this PR do?

This test had a BUILD_ID skip that I'm fairly certain is jenkins-specific. You can see it running and failing a fair bit on https://github.com/elastic/beats/actions/workflows/macos-auditbeat.yml?query=is%3Afailure

I've replaced it with CI since that seems like a good generic option and provided by github actions. I'm unclear on if jenkins will provide it or not. Hoping @andrewkroh or @v1v can confirm before merge.

Why is it important?

The tests are running but flakey, causing error messages and (at best) wasted investigation cycles or (at worst) tendency to ignore test suite failures.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@matschaffer
Switch skip to use CI
d137510 
Fairly certain `BUILD_ID` is jenkins-specific.
@matschaffer matschaffer added Team:Automation Label for the Observability productivity team Team:Security-External Integrations labels Feb 22, 2022
@matschaffer matschaffer self-assigned this Feb 22, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2022

This pull request does not have a backport label. Could you fix it @matschaffer? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 22, 2022
@matschaffer matschaffer added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 22, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-22T01:54:48.408+0000

  • Duration: 74 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 568
Skipped 65
Total 633

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

v1v
v1v approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mat, Jenkins actually provides the CI env variable too.

image

https://beats-ci.elastic.co/pipeline-syntax/globals#env

@matschaffer matschaffer merged commit ca4a87a into elastic:main Feb 22, 2022
mergify bot pushed a commit that referenced this pull request Feb 22, 2022
@matschaffer
Switch skip to use CI (#30512)
e9f1c51 
Fairly certain `BUILD_ID` is jenkins-specific.

(cherry picked from commit ca4a87a)
@mergify mergify bot mentioned this pull request Feb 22, 2022
Merged
@matschaffer matschaffer deleted the 30510-update-auditbeat-test-skip branch February 22, 2022 09:56
mergify bot pushed a commit that referenced this pull request Feb 22, 2022
@matschaffer
Switch skip to use CI (#30512)
6bdcabf 
Fairly certain `BUILD_ID` is jenkins-specific.

(cherry picked from commit ca4a87a)
@mergify mergify bot mentioned this pull request Feb 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 22, 2022
@matschaffer
Switch skip to use CI (#30512)
76bc6c3 
Fairly certain `BUILD_ID` is jenkins-specific.

(cherry picked from commit ca4a87a)
@mergify mergify bot mentioned this pull request Feb 22, 2022
Merged
matschaffer added a commit that referenced this pull request Feb 22, 2022
@mergify @matschaffer
[8.1](backport #30512) Switch skip to use CI (#30525)
f12107b 
Co-authored-by: Mat Schaffer <[email protected]>
matschaffer added a commit that referenced this pull request Feb 22, 2022
@mergify @matschaffer
[8.0](backport #30512) Switch skip to use CI (#30524)
259f54e 
Co-authored-by: Mat Schaffer <[email protected]>
matschaffer added a commit that referenced this pull request Feb 22, 2022
@mergify @matschaffer
[7.17](backport #30512) Switch skip to use CI (#30523)
1be7963 
Co-authored-by: Mat Schaffer <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Feb 22, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/refactor-pa…
29471a7 
…ckaging-docker

* upstream/main: (26 commits)
  Update docker/distribution to 2.8.0 (elastic#30462)
  Add `parsers` examples to `filestream` reference configuration (elastic#30529)
  extend documentation about setting orchestrator.cluster fields (elastic#30518)
  Forward-port 8.0.1 changelog to main (elastic#30522)
  Switch skip to use `CI` (elastic#30512)
  packetbeat/beater: don't attempt to install npcap when already installed (elastic#30509)
  Fix Docker module: rename fields on dashboards (elastic#30500)
  fix typos and improve sentences (elastic#30432)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440)
  {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321)
  Spelling fix (elastic#30439)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438)
  Add BC about Homebrew no longer being available in 8.0 (elastic#30419)
  Install gawk as a replacement for mawk in Docker containers. (elastic#30452)
  Clean up python-related system tests (elastic#30415)
  Fix TestNewModuleRegistry flakiness (elastic#30453)
  [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382)
  Set `log.offset` to the start of the reported line in filestream (elastic#30445)
  clarify SelectedPackageTypes meaning and improve its usage (elastic#30142)
  [elasticsearch module] serialize shards properties (elastic#30408)
  ...
v1v added a commit to v1v/beats that referenced this pull request Feb 22, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-with-ki…
12a61e7 
…nd-k8s-env

* upstream/main:
  Update docker/distribution to 2.8.0 (elastic#30462)
  Add `parsers` examples to `filestream` reference configuration (elastic#30529)
  extend documentation about setting orchestrator.cluster fields (elastic#30518)
  Forward-port 8.0.1 changelog to main (elastic#30522)
  Switch skip to use `CI` (elastic#30512)
  packetbeat/beater: don't attempt to install npcap when already installed (elastic#30509)
  Fix Docker module: rename fields on dashboards (elastic#30500)
v1v added a commit that referenced this pull request Mar 2, 2022
@v1v
Merge branch '8.1' of github.com:elastic/beats into mergify/bp/8.1/pr…
0112148 
…-29710

* '8.1' of github.com:elastic/beats: (51 commits)
  refactor pushDockerImages (#30414) (#30624)
  ci: add windows-2022 in the extended meta-stage (#30528) (#30630)
  Curate k8s testing versions to only keep the actively maintained (#30619) (#30625)
  [8.1](backport #30355) Add Beats upgrade docs for 8.0 (#30612)
  Remove references to gcp from the Functionbeat docs (#30579) (#30609)
  x-pack/auditbeat/module/system/socket: defend against exec with zero arguments (#30586) (#30597)
  [MySQL Enterprise] Adding default paths values to manifest.yml (#30598) (#30604)
  metricbeat - fix elasticsearch and kibana integration tests failures in 8.0 (#30566) (#30594)
  Install gawk as a replacement for mawk in Docker containers. (#30452) (#30465)
  [Filebeat] Remove RecordedFuture dataset from Threat Intel module (#30564) (#30568)
  Adjust the documentation of `backoff` options in filestream input (#30552) (#30557)
  packetbeat/beater: help the GC clean up the Npcap installer if it's not used (#30513) (#30546)
  Osquerybeat: Add install verification for osquerybeat (#30388) (#30404)
  Update docker/distribution to 2.8.0 (#30462) (#30540)
  Add `parsers` examples to `filestream` reference configuration (#30529) (#30537)
  [8.1](backport #30068) ZooKeeper module: Adapt to ZooKeeper 3.6+ `mntr` response fields' changes. (#30360)
  [8.1](backport #30512) Switch skip to use `CI` (#30525)
  Forward-port 8.0.1 changelog to 8.1 (#30517)
  packetbeat/beater: don't attempt to install npcap when already installed (#30509) (#30511)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (#30440) (#30488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@matschaffer matschaffer

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matschaffer @elasticmachine @v1v