Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nanosecond precision timestamps #31553

Merged
merged 9 commits into from
May 16, 2022

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 9, 2022

What does this PR do?

This PR adds support for nanosecond precision timestamps in Beats. It is the updated version of #15872

Why is it important?

When events come faster then milliseconds, ingested events might have the same @timestamp field. So there is no way to order them correctly. By making the timestamp more precise we can avoid such problems.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #15871

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2022
@mergify mergify bot assigned kvch May 9, 2022
@kvch kvch mentioned this pull request May 9, 2022
21 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T17:10:38.700+0000

  • Duration: 105 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 22618
Skipped 1938
Total 24556

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kvch kvch changed the title Feature timestamp nano Add support for nanosecond precision timestamps May 10, 2022
@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 10, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2022
@kvch kvch marked this pull request as ready for review May 10, 2022 12:08
@kvch kvch requested review from a team as code owners May 10, 2022 12:08
@kvch kvch requested review from fearful-symmetry and removed request for a team May 10, 2022 12:08
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@kvch kvch requested a review from faec May 10, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for nanosecond timestamps
4 participants