-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the queue's public API accept interface{} instead of publisher.Event #31699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faec
added
enhancement
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
labels
May 20, 2022
faec
requested review from
cmacknz and
fearful-symmetry
and removed request for
a team
May 20, 2022 15:44
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
May 20, 2022
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
May 20, 2022
Collaborator
cmacknz
reviewed
May 20, 2022
This is ready for review now (the tests pass, locally at least) |
fearful-symmetry
approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, my LGTM is limited to the memqueue, since that's really the only part I understand, but it looks fine.
cmacknz
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finishes the refactor started in #31356, modifying the public queue API to accept and return
interface{}
pointers rather thanpublisher.Event
, which will allow the new elastic shipper to use the libbeat queue for its internal storage.Closes #31307
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.