Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port test_type_in_message to filestream Golang tests #32032

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 22, 2022

What does this PR do?

This PR ports existing Python tests of log input to filesteam. The PR contains the test cases for test_type_in_message. Thus, the tests in Python can be disabled/removed.

Why is it important?

Decrease the amount of low-quality E2E tests.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 22, 2022
@kvch kvch requested a review from a team as a code owner June 22, 2022 09:13
@kvch kvch requested review from belimawr and faec and removed request for a team June 22, 2022 09:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 22, 2022
@mergify mergify bot assigned kvch Jun 22, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-22T15:03:49.915+0000

  • Duration: 48 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 7511
Skipped 1101
Total 8612

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kvch
Copy link
Contributor Author

kvch commented Jun 22, 2022

Failing tests are unrelated.

@kvch
Copy link
Contributor Author

kvch commented Jun 22, 2022

/test

@kvch kvch merged commit effc247 into elastic:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants