Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 #32259

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 #32259

merged 1 commit into from
Jul 11, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jul 7, 2022 •
edited
Loading

What does this PR do?

Fix OS name reported by add_host_metadata on Windows 11.

https://github.com/elastic/go-sysinfo/releases/tag/v1.8.1

Fixes #30833

Why is it important?

Prior to this fix, Windows 11 was being reported as Windows 10.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh andrewkroh added the bug label Jul 7, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 7, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 7, 2022
@andrewkroh andrewkroh marked this pull request as ready for review July 7, 2022 20:16
@andrewkroh andrewkroh requested a review from a team as a code owner July 7, 2022 20:16
@andrewkroh andrewkroh requested review from faec and leehinman and removed request for a team July 7, 2022 20:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@andrewkroh andrewkroh added backport-v8.3.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jul 7, 2022
cmacknz
cmacknz approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Also thanks Microsoft for making this bug possible...

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 7, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-08T17:02:23.054+0000

  • Duration: 111 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 22413
Skipped 1937
Total 24350

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23
Copy link
Collaborator

jlind23 commented Jul 8, 2022

/test

@andrewkroh
Copy link
Member Author

andrewkroh commented Jul 8, 2022 •
edited
Loading

Packaging failure is caused by:

[2022-07-08T04:29:15.709Z] osxcross: error: xcrun: cannot find 'dsymutil' executable

I cannot find an open issue for this problem. I assume it's an issue with golang-crossbuild.

update: elastic/golang-crossbuild#217

@andrewkroh
Copy link
Member Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2022

rebase

✅ Branch has been successfully rebased

@andrewkroh andrewkroh merged commit 86bb5f3 into elastic:main Jul 11, 2022
@mergify mergify bot mentioned this pull request Jul 11, 2022
Merged
@mergify mergify bot mentioned this pull request Jul 11, 2022
Merged
andrewkroh added a commit that referenced this pull request Jul 11, 2022
@andrewkroh
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (#32259)
9fca64c 
Fixes #30833
andrewkroh added a commit that referenced this pull request Jul 11, 2022
@andrewkroh
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (#32259)
4f76467 
Fixes #30833

(cherry picked from commit 86bb5f3)
andrewkroh added a commit that referenced this pull request Jul 11, 2022
@mergify @andrewkroh
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (#32259) (#32304)
50960f2 
Fixes #30833

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Jul 12, 2022
@mergify @andrewkroh
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (#32259) (#32303)
4b39126 
Fixes #30833

(cherry picked from commit 86bb5f3)

Co-authored-by: Andrew Kroh <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @andrewkroh
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (elastic#32259) (
9aed24d 
elastic#32304)

Fixes elastic#30833

Co-authored-by: Andrew Kroh <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@andrewkroh @chrisberkhout
Upgrade github.com/elastic/go-sysinfo v1.8.0 => v1.8.1 (#32259)
564daae 
Fixes #30833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@cmacknz cmacknz cmacknz approved these changes

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@andrewkroh andrewkroh

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.3.0 Automated backport with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metricbeat system modules reports Windows 11 as Windows 10
5 participants
@andrewkroh @elasticmachine @jlind23 @cmacknz @efd6