Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how decode_xml_wineventlog maps fields #32456

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Jul 21, 2022

What does this PR do?

Documents the field mappings for the decode_xml_wineventlog processor.

Why is it important?

Needed so users will know what fields will be populated so they can filter on them in Conditionals or Logstash.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

Screen Shot 2022-07-21 at 14 57 41

Screen Shot 2022-07-21 at 14 58 14

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 21, 2022
@leehinman leehinman force-pushed the decode_xml_wineventlog_docs branch from 3260f7a to 0486f79 Compare July 21, 2022 20:33
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b decode_xml_wineventlog_docs upstream/decode_xml_wineventlog_docs
git merge upstream/main
git push upstream decode_xml_wineventlog_docs

@leehinman leehinman force-pushed the decode_xml_wineventlog_docs branch from 0486f79 to db80c45 Compare July 21, 2022 20:34
@leehinman leehinman marked this pull request as ready for review July 21, 2022 20:36
@leehinman leehinman requested a review from a team as a code owner July 21, 2022 20:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T16:08:35.602+0000

  • Duration: 20 min 12 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b decode_xml_wineventlog_docs upstream/decode_xml_wineventlog_docs
git merge upstream/main
git push upstream decode_xml_wineventlog_docs

@leehinman leehinman force-pushed the decode_xml_wineventlog_docs branch from db80c45 to 5817c88 Compare July 22, 2022 16:08
@leehinman leehinman merged commit 7cb3960 into elastic:main Jul 22, 2022
@leehinman leehinman deleted the decode_xml_wineventlog_docs branch July 22, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants