Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] (backport elastic-agent#718) Allow / to be used in variable names #32528

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

michel-laterman
Copy link
Contributor

Backport elastic/elastic-agent#718

  • Allow the / character to be used in variable names.

Allow / to be used in variable names from dynamic providers and eql
expressions. Ensure that k8s providers can provide variables with
slashes in their names.

  • run antlr4

  • Fix tests

Backport elastic/elastic-agent#718

* Allow the / character to be used in variable names.

Allow / to be used in variable names from dynamic providers and eql
expressions. Ensure that k8s providers can provide variables with
slashes in their names.

* run antlr4

* Fix tests
@michel-laterman michel-laterman added bug backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jul 27, 2022
@michel-laterman michel-laterman requested a review from a team as a code owner July 27, 2022 17:37
@michel-laterman michel-laterman requested review from narph and blakerouse and removed request for a team July 27, 2022 17:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T18:08:57.126+0000

  • Duration: 110 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 6144
Skipped 393
Total 6537

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@michel-laterman
Copy link
Contributor Author

@michel-laterman michel-laterman merged commit d2828cf into elastic:7.17 Jul 28, 2022
@michel-laterman michel-laterman deleted the backport-agent-718 branch July 28, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants