-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistence acknowledgement support for shipper #32708
Conversation
d383836
to
9d1cde0
Compare
Now the shipper output is able to receive acknowledgement of the persisted events from the shipper server. Also, added the UUID verification in case the client is reconnected to a different server.
9d1cde0
to
bd87ee6
Compare
This pull request does not have a backport label.
|
E2E test failure is not related to the change:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. I think we'll need a way to benchmark throughput between a beat and the shipper to really know how well this performs.
Also terminate the stream properly with the context.
Now the shipper output is able to receive acknowledgement of the persisted events from the shipper server. Also, added the UUID verification in case the client is reconnected to a different server.
What does this PR do?
Now the shipper output is able to receive acknowledgement of the
persisted events from the shipper server.
Also, added the UUID verification in case the client is reconnected to
a different server.
Why is it important?
To avoid data loss.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
PersistedIndex
notAcceptedCount
#32329