Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/packetbeat: bump npcap version to v1.71 #33172

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 23, 2022

What does this PR do?

This bundles the most recent version of the Npcap library installer for Windows.

Tested locally on Windows 2022:

  • upgrades previous install:✅
  • installs on pristine:✅
  • gets network events:✅

Why is it important?

It brings a number of improvements from the previous version that was included with packetbeat.

https://github.com/nmap/npcap/blob/master/CHANGELOG.md

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Query whether this should be back-ported to v8.5.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Sep 23, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 23, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-23T14:29:04.894+0000

  • Duration: 28 min 28 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member

v1v commented Sep 23, 2022

/test

@efd6 efd6 marked this pull request as ready for review September 23, 2022 21:24
@efd6 efd6 requested a review from a team as a code owner September 23, 2022 21:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 added backport-v8.5.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 27, 2022
@efd6 efd6 merged commit cb74103 into elastic:main Sep 27, 2022
mergify bot pushed a commit that referenced this pull request Sep 27, 2022
efd6 added a commit that referenced this pull request Sep 27, 2022
(cherry picked from commit cb74103)

Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Packetbeat] Upgrade NPCAP Version
4 participants