Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect ES field #33263

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Oct 6, 2022

What does this PR do?

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

Why is it important?

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json, isn't populated by the module code, also doesn't make sense that we'd have bytes under a time grouping.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Set up from-source monitoring

Run the Elasticsearch module in default mode

http.enabled: true
http.host: "0.0.0.0"

metricbeat.modules:
  - module: elasticsearch
    period: 10s
    hosts:
      - "localhost:9200"
    username: "elastic"
    password: "changeme"

  - module: kibana
    basepath: "/ftw"
    period: 10s
    hosts: [ "localhost:5601" ]
    username: "elastic"
    password: "changeme"

output.elasticsearch:
  hosts: [ "localhost:9200" ]
  username: "elastic"
  password: "changeme"

Note lack of elasticsearch > node > stats > indices > bulk > avg_time > bytes in mappings.

Related issues

Closes #33211

Use cases

Using the elasticsearch metricbeat module to monitor elasticsearch in non-xpack mode.

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping.
@matschaffer matschaffer added bug Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring labels Oct 6, 2022
@matschaffer matschaffer self-assigned this Oct 6, 2022
@matschaffer matschaffer requested a review from a team as a code owner October 6, 2022 05:05
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @matschaffer? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@matschaffer matschaffer added the backport-v8.5.0 Automated backport with mergify label Oct 6, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T02:30:56.531+0000

  • Duration: 49 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 3883
Skipped 884
Total 4767

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 33211-update-es-mappings upstream/33211-update-es-mappings
git merge upstream/main
git push upstream 33211-update-es-mappings

@Kerry350 Kerry350 self-requested a review October 10, 2022 11:12
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matschaffer matschaffer merged commit 1032646 into elastic:main Oct 11, 2022
mergify bot pushed a commit that referenced this pull request Oct 11, 2022
* Remove incorrect ES field

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping.

* Changelog entry

* More whitespace fiddling

(cherry picked from commit 1032646)

# Conflicts:
#	metricbeat/module/elasticsearch/fields.go
matschaffer added a commit that referenced this pull request Oct 12, 2022
* Remove incorrect ES field (#33263)

* Remove incorrect ES field

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping.

* Changelog entry

* More whitespace fiddling

(cherry picked from commit 1032646)

# Conflicts:
#	metricbeat/module/elasticsearch/fields.go

* metricbeat: make update

Co-authored-by: Mat Schaffer <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Remove incorrect ES field

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json and also doesn't make sense that we'd have bytes under a time grouping.

* Changelog entry

* More whitespace fiddling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.5.0 Automated backport with mergify bug Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Update metricbeat's elasticsearch mappings
3 participants