-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for Metricbeat on K8s #33308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
added
review
Metricbeat
Metricbeat
Team:Cloudnative-Monitoring
Label for the Cloud Native Monitoring team
labels
Oct 11, 2022
constanca-m
requested review from
fearful-symmetry and
faec
and removed request for
a team
October 11, 2022 13:22
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 11, 2022
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Collaborator
gsantoro
reviewed
Oct 11, 2022
gsantoro
requested changes
Oct 11, 2022
gsantoro
reviewed
Oct 11, 2022
gsantoro
reviewed
Oct 12, 2022
gsantoro
reviewed
Oct 12, 2022
gsantoro
reviewed
Oct 12, 2022
gsantoro
reviewed
Oct 12, 2022
gsantoro
reviewed
Oct 12, 2022
gsantoro
reviewed
Oct 12, 2022
…me-mb-k8s # Conflicts: # deploy/kubernetes/metricbeat/README.md
gsantoro
approved these changes
Oct 12, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Update README.md for Metricbeat on K8s * Update README.md for Metricbeat on K8s * Clarified README.md for Metricbeat on K8s * Deleted HTML in README.md for Metricbeat on K8s * Apply suggestions from code review * Align table * Align table Co-authored-by: Giuseppe Santoro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated README.md file for Metricbeat on Kubernetes to explain to the user how to run Metricbeat locally or on cloud.
Why is it important?
The updated file makes clear to the user how to run Metricbeat on Kubernetes.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist