Get-WmiObject - Invalid class "Win32_Service" - Workaround #33322

stryngs · 2022-10-12T02:15:59Z

What does this PR do?

This PR adds a workaround to a situation in Windows where calling Get-WmiObject returns "Win32_Service" as an Invalid class.

Why is it important?

This is important to users which remotely deploy and install any of the Beats in a Windows environment. Rather than solving the class issue I focused on a workaround which can be provided until a proper solution to the class issue is found.

Checklist

My code follows the style guidelines of this project
~~- [ ] I have commented my code, particularly in hard-to-understand areas~~
~~- [ ] I have made corresponding changes to the documentation~~
~~- [ ] I have made corresponding change to the default configuration files~~
~~- [ ] I have added tests that prove my fix is effective or that my feature works~~
~~- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.~~

Author's Checklist

N/A

How to test this PR locally

Build any Beats package and then run the associated installer for Windows.

Related issues

N/A

Use cases

Windows zipfile deployments for service installations.

Screenshots

N/A

Logs

N/A

cla-checker-service · 2022-10-12T02:16:04Z

💚 CLA has been signed

mergify · 2022-10-12T02:16:35Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stryngs? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

stryngs · 2022-10-12T02:19:17Z

x Author of the following commits did not sign a Contributor Agreement: 257f588, a5eae20

Please, read and sign the above mentioned agreement if you want to contribute to this project

Signed.

elasticmachine · 2022-10-12T02:21:17Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-03T12:52:40.010+0000
Duration: 111 min 22 sec

Test stats 🧪

Test	Results
Failed	0
Passed	23739
Skipped	1951
Total	25690

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2022-10-12T17:23:33Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

cmacknz · 2022-10-12T17:24:47Z

/test

stryngs · 2022-10-18T03:37:02Z

What do I need to do to keep this moving forward?

cmacknz · 2022-10-18T19:59:27Z

@leehinman is looking at this. The main concern is making sure this change will work as expected across the various Windows versions we need to support.

stryngs · 2022-10-19T04:37:31Z

Awesome and glad to hear it.

leehinman

Will also need a changelog entry.

leehinman · 2022-10-20T16:39:27Z

dev-tools/packaging/templates/windows/install-service.ps1.tmpl

-  $service.StopService()
-  Start-Sleep -s 1
-  $service.delete()
+  try {


Lets not do the try/catch and just change to the code in the catch block.

I tested the code in the catch block on Windows 11, Windows Server 2012, 2016 & 2019. Works fine.

I made the requested changes, please let me know if there is anything further needed. Thanks for moving so quick on this!

stryngs · 2022-11-02T06:21:45Z

What else needs to be done for this?

mergify · 2022-11-02T15:39:23Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

leehinman

LGTM

cmacknz · 2022-11-02T15:43:16Z

We just need the merge conflict in the changelog resolved and we can merge this.

stryngs · 2022-11-02T16:44:51Z

I'm not the best with git. I tried the steps and got this:

~/beats$ git fetch upstream
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

What can I do to fix?

cmacknz · 2022-11-02T19:20:53Z

I was able to resolve the conflict on your branch myself via the GitHub UI. The command above is assuming you set the elastic/beats repository as a remote named upstream. You can run git remote -v to see which remote name references the elastic/beats repository instead of your fork of it.

mergify · 2022-11-03T09:43:58Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

cmacknz · 2022-11-03T17:54:57Z

Merged! This will be in the 8.6 release for Beats.

stryngs · 2023-03-13T17:45:28Z

I'm looking at 8.6.2 and still do not see this pulled in?

cmacknz · 2023-03-21T00:23:03Z

It should be in 8.6.2, Git certainly thinks it is looking at the tags on the merged commit 4e58e31

stryngs · 2023-05-05T05:01:39Z

We have 8.6.2 on site and I need to apply this change by hand. Maybe someone didn't push a specific button or?

cmacknz · 2023-05-05T15:29:07Z

The commit is part of the 8.6.2 release, Git shows that it is and you can see it if you go far enough back in the 8.6.2 commit history. It is one of the last commits in https://github.com/elastic/beats/commits/v8.6.2?after=9b77c2c135c228c2eedc310f6e975bb1a76169b1+139&branch=v8.6.2&qualified_name=refs%2Ftags%2Fv8.6.2

If it isn't working it is possible something was missed as part of the fix here, possibly something that is part of the build and packaging step.

* Get-WmiObject - Invalid class "Win32_Service" - Workaround * try/catch replace + changelog documentation * Changelog fix Co-authored-by: Lee E. Hinman <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>

BrunoMacias · 2023-08-23T17:39:51Z

Was there more information about the root cause of win32_service issues?

stryngs · 2024-03-22T03:35:03Z

The commit is part of the 8.6.2 release, Git shows that it is and you can see it if you go far enough back in the 8.6.2 commit history. It is one of the last commits in https://github.com/elastic/beats/commits/v8.6.2?after=9b77c2c135c228c2eedc310f6e975bb1a76169b1+139&branch=v8.6.2&qualified_name=refs%2Ftags%2Fv8.6.2

If it isn't working it is possible something was missed as part of the fix here, possibly something that is part of the build and packaging step.

This never made it into the release. I am currently working at 8.11.x and not seeing it.

Get-WmiObject - Invalid class "Win32_Service" - Workaround

257f588

stryngs requested a review from a team as a code owner October 12, 2022 02:16

stryngs requested review from cmacknz and leehinman and removed request for a team October 12, 2022 02:16

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 12, 2022

Merge branch 'main' into main

a5eae20

mergify bot assigned stryngs Oct 12, 2022

cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 12, 2022

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 12, 2022

Merge branch 'main' into main

7192f6d

Merge branch 'main' into main

31b1e0b

leehinman requested changes Oct 20, 2022

View reviewed changes

stryngs and others added 5 commits October 20, 2022 23:00

Merge branch 'main' into main

afbcb8f

try/catch replace + changelog documentation

01db829

Merge branch 'main' of https://github.com/stryngs/beats

0412500

Merge branch 'main' into main

28a8aff

Merge branch 'main' into main

857fe61

cmacknz requested a review from leehinman November 2, 2022 14:41

Changelog fix

c0b9edf

leehinman approved these changes Nov 2, 2022

View reviewed changes

Merge branch 'main' into main

1ca4754

Merge branch 'main' into main

cd36a13

cmacknz added v8.6.0 QA:Needs Validation Needs validation by the QA Team labels Nov 3, 2022

cmacknz merged commit 4e58e31 into elastic:main Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get-WmiObject - Invalid class "Win32_Service" - Workaround #33322

Get-WmiObject - Invalid class "Win32_Service" - Workaround #33322

stryngs commented Oct 12, 2022 •

edited

Loading

cla-checker-service bot commented Oct 12, 2022 •

edited

Loading

mergify bot commented Oct 12, 2022

stryngs commented Oct 12, 2022

elasticmachine commented Oct 12, 2022 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

elasticmachine commented Oct 12, 2022

cmacknz commented Oct 12, 2022

stryngs commented Oct 18, 2022

cmacknz commented Oct 18, 2022

stryngs commented Oct 19, 2022

leehinman left a comment

leehinman Oct 20, 2022

stryngs Oct 21, 2022

stryngs commented Nov 2, 2022

mergify bot commented Nov 2, 2022

leehinman left a comment

cmacknz commented Nov 2, 2022

stryngs commented Nov 2, 2022

cmacknz commented Nov 2, 2022

mergify bot commented Nov 3, 2022

cmacknz commented Nov 3, 2022

stryngs commented Mar 13, 2023

cmacknz commented Mar 21, 2023

stryngs commented May 5, 2023

cmacknz commented May 5, 2023

BrunoMacias commented Aug 23, 2023

stryngs commented Mar 22, 2024

Get-WmiObject - Invalid class "Win32_Service" - Workaround #33322

Get-WmiObject - Invalid class "Win32_Service" - Workaround #33322

Conversation

stryngs commented Oct 12, 2022 • edited Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

cla-checker-service bot commented Oct 12, 2022 • edited Loading

mergify bot commented Oct 12, 2022

stryngs commented Oct 12, 2022

elasticmachine commented Oct 12, 2022 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

elasticmachine commented Oct 12, 2022

cmacknz commented Oct 12, 2022

stryngs commented Oct 18, 2022

cmacknz commented Oct 18, 2022

stryngs commented Oct 19, 2022

leehinman left a comment

Choose a reason for hiding this comment

leehinman Oct 20, 2022

Choose a reason for hiding this comment

stryngs Oct 21, 2022

Choose a reason for hiding this comment

stryngs commented Nov 2, 2022

mergify bot commented Nov 2, 2022

leehinman left a comment

Choose a reason for hiding this comment

cmacknz commented Nov 2, 2022

stryngs commented Nov 2, 2022

cmacknz commented Nov 2, 2022

mergify bot commented Nov 3, 2022

cmacknz commented Nov 3, 2022

stryngs commented Mar 13, 2023

cmacknz commented Mar 21, 2023

stryngs commented May 5, 2023

cmacknz commented May 5, 2023

BrunoMacias commented Aug 23, 2023

stryngs commented Mar 22, 2024

stryngs commented Oct 12, 2022 •

edited

Loading

cla-checker-service bot commented Oct 12, 2022 •

edited

Loading

elasticmachine commented Oct 12, 2022 •

edited by jenkins-beats-ci bot

Loading