-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id. #33555
Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id. #33555
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue mentions that atleast these 2 fields were deprecated from previous version.
I think it would be worthwhile to see what other fields got deprecated between these 2 kafka versions. To avoid any further issues.
Otherwise, the change looks good
@@ -61,7 +61,7 @@ | |||
"split_color_mode": "rainbow", | |||
"split_mode": "terms", | |||
"stacked": "none", | |||
"terms_field": "kafka.consumergroup.topic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these fields present in the field mapping.
Do we need to do some changes there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check if any of these need to dropped from integration field mapping. Also briefly check, if any obsolete field still used. Not planning to do major kafka package changes for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also updated for "kafka.consumergroup.partition -> kafka.partition.id".
The corresponding integration PR elastic/integrations#4530 has many old filed mapping that are getting dropped.
6b6e2ee
to
c2e5b4f
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This pull request is now in conflicts. Could you fix it? 🙏
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
…33555) * Fix kafka dashboard field names correctly to kafka.topic.name and kafka.partition.id
What does this PR do?
Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id
Why is it important?
The kafka dashboard was broken.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Run Metricbeat against a working kafka cluster.
Related issues
Screenshots
Before:
After: