Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id. #33555

Merged
merged 5 commits into from
Dec 26, 2022

Conversation

lalit-satapathy
Copy link
Contributor

What does this PR do?

Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id

Why is it important?

The kafka dashboard was broken.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Run Metricbeat against a working kafka cluster.

Related issues

Screenshots

Before:
beats kafka before

After:
Beats Kafka after

@lalit-satapathy lalit-satapathy added bug Team:Service-Integrations Label for the Service Integrations team labels Nov 2, 2022
@lalit-satapathy lalit-satapathy self-assigned this Nov 2, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b kafka-update-dashboard upstream/kafka-update-dashboard
git merge upstream/main
git push upstream kafka-update-dashboard

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @lalit-satapathy? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T04:48:41.483+0000

  • Duration: 55 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 3963
Skipped 881
Total 4844

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lalit-satapathy lalit-satapathy marked this pull request as ready for review November 4, 2022 07:57
@lalit-satapathy lalit-satapathy requested a review from a team as a code owner November 4, 2022 07:57
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions that atleast these 2 fields were deprecated from previous version.
I think it would be worthwhile to see what other fields got deprecated between these 2 kafka versions. To avoid any further issues.

Otherwise, the change looks good

@@ -61,7 +61,7 @@
"split_color_mode": "rainbow",
"split_mode": "terms",
"stacked": "none",
"terms_field": "kafka.consumergroup.topic",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these fields present in the field mapping.
Do we need to do some changes there as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check if any of these need to dropped from integration field mapping. Also briefly check, if any obsolete field still used. Not planning to do major kafka package changes for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated for "kafka.consumergroup.partition -> kafka.partition.id".

The corresponding integration PR elastic/integrations#4530 has many old filed mapping that are getting dropped.

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b kafka-update-dashboard upstream/kafka-update-dashboard
git merge upstream/main
git push upstream kafka-update-dashboard

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b kafka-update-dashboard upstream/kafka-update-dashboard
git merge upstream/main
git push upstream kafka-update-dashboard

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@lalit-satapathy lalit-satapathy merged commit 2c21577 into elastic:main Dec 26, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
…33555)

* Fix kafka dashboard field names correctly to kafka.topic.name and kafka.partition.id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants