[Filebeat] Treat filebeat.events.active as gauge in monitoring log reporter #33597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
Filebeat
botelastic
bot
added
needs_team
andrewkroh
added
needs_team
botelastic
bot
removed
the
needs_team
The monitoring log reporting applies serial differencing to the filebeat.events.active value. But this value is used as a gauge by Filebeat so it can increase and decrease. So by reporting `current - prev` this can result in negative values that are not meaningful.
andrewkroh
force-pushed
the
bugfix/fb/active-events-gauge
branch
from
4389dcd
to
1cd5d4f
Compare
andrewkroh
requested review from
cmacknz and
leehinman
and removed request for
a team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Reconstructing a nested map from the flattened scalars should never result in a conflict.
|
/test |
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…porter (#33597) * Treat filebeat.events.active as gauge in monitoring log reporter The monitoring log reporting applies serial differencing to the filebeat.events.active value. But this value is used as a gauge by Filebeat so it can increase and decrease. So by reporting `current - prev` this can result in negative values that are not as useful as knowing the full amount of active events. * Ignore errcheck warnings Reconstructing a nested map from the flattened scalars should never result in a conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The monitoring log reporting applies serial differencing to the filebeat.events.active value. But this value is used as a gauge by Filebeat so it can increase and decrease. So by reporting
current - prevthis can result in negative values that are not as useful as knowing the full amount of active events.This metric is decremented when an event is ACked.
Why is it important?
It helps when analyzing logs that contain "Non-zero metrics in the last 30s".
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.