Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][Google workspace] Backport integration fixes #33666

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 14, 2022

What does this PR do?

Backports fixes made in the google workspace integration.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding change to the default configuration files
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Closes #33636

- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams
@marc-gr marc-gr added Team:Security-External Integrations backport-7.17 Automated backport to the 7.17 branch with mergify bugfix backport-v8.5.0 Automated backport with mergify labels Nov 14, 2022
@marc-gr marc-gr requested a review from a team as a code owner November 14, 2022 09:27
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-14T10:31:34.460+0000

  • Duration: 72 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 2319
Skipped 167
Total 2486

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 311b137 into elastic:main Nov 14, 2022
@marc-gr marc-gr deleted the gw-backport branch November 14, 2022 14:50
mergify bot pushed a commit that referenced this pull request Nov 14, 2022
* Backport integration improvements:
- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams

* Add changelog entry

* Add processing for user_accounts event parameters

* Add PR number

* Ensure only scalars are added to generate the id

(cherry picked from commit 311b137)

# Conflicts:
#	x-pack/filebeat/module/google_workspace/config/common.js
mergify bot pushed a commit that referenced this pull request Nov 14, 2022
* Backport integration improvements:
- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams

* Add changelog entry

* Add processing for user_accounts event parameters

* Add PR number

* Ensure only scalars are added to generate the id

(cherry picked from commit 311b137)
marc-gr added a commit that referenced this pull request Nov 15, 2022
)

* Backport integration improvements:
- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams

* Add changelog entry

* Add processing for user_accounts event parameters

* Add PR number

* Ensure only scalars are added to generate the id

(cherry picked from commit 311b137)

Co-authored-by: Marc Guasch <[email protected]>
marc-gr added a commit that referenced this pull request Nov 15, 2022
…tion fixes (#33670)

* [Filebeat][Google workspace] Backport integration fixes (#33666)

* Backport integration improvements:
- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams

* Add changelog entry

* Add processing for user_accounts event parameters

* Add PR number

* Ensure only scalars are added to generate the id

(cherry picked from commit 311b137)

# Conflicts:
#	x-pack/filebeat/module/google_workspace/config/common.js

* Fix backport

Co-authored-by: Marc Guasch <[email protected]>
Co-authored-by: Marc Guasch <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Backport integration improvements:
- Use event for google workspace fingerprint
- Fix pagination and cursor for google workspace data streams

* Add changelog entry

* Add processing for user_accounts event parameters

* Add PR number

* Ensure only scalars are added to generate the id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[filebeat] Add script to parse event paramenters for user_accounts
3 participants