Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/cel: add support for http+{unix,npipe} schemes #33712

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 17, 2022

What does this PR do?

This adds support for requests to endpoints over Unix sockets and Windows named pipes using the https?+(unix|npipe) schemes. No testing at this stage since cel test infrastructure assumes a TCP transport.

It also marks the cel input as owned by SEI to avoid troubling agent-data-plane in the future.

Why is it important?

From #33571

This would be used connect to internal services that are only exposed locally. Services like Beats HTTP monitoring endpoint and Docker have APIs that listen on unix sockets. It would be useful if httpjson (and any future inputs that also monitor arbitrary HTTP services) could monitor data from these local APIs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Query inclusion in 8.6 backport for 8.6.1.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.7-candidate labels Nov 17, 2022
@efd6 efd6 requested a review from andrewkroh November 17, 2022 03:10
@efd6 efd6 self-assigned this Nov 17, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 17, 2022
Also explicitly add cel to elastic/security-external-integrations
ownership list.
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-17T03:13:49.758+0000

  • Duration: 73 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 2505
Skipped 167
Total 2672

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review November 17, 2022 04:38
@efd6 efd6 requested a review from a team as a code owner November 17, 2022 04:38
@efd6 efd6 requested review from belimawr and cmacknz and removed request for a team November 17, 2022 04:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit cd547c6 into elastic:main Nov 18, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
…33712)

Also explicitly add cel to elastic/security-external-integrations
ownership list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants