Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in handling states and purging #33722

Merged
merged 11 commits into from
Dec 12, 2022
Merged

fix in handling states and purging #33722

merged 11 commits into from
Dec 12, 2022

Conversation

aspacca
Copy link

@aspacca aspacca commented Nov 18, 2022

Bug

What does this PR do?

Handles error state for s3 direct listing when purging registry and checking if an s3 object has to be skipped

Why is it important?

see #33513

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2022
@aspacca aspacca marked this pull request as ready for review November 18, 2022 02:30
@aspacca aspacca requested a review from a team as a code owner November 18, 2022 02:30
@aspacca aspacca self-assigned this Nov 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @aspacca? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@aspacca aspacca added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 18, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2022
@aspacca aspacca added backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 18, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-05T06:02:55.949+0000

  • Duration: 131 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 5044
Skipped 340
Total 5384

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-33513 upstream/issue-33513
git merge upstream/main
git push upstream issue-33513

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-33513 upstream/issue-33513
git merge upstream/main
git push upstream issue-33513

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@tommyers-elastic tommyers-elastic merged commit 01f9d43 into elastic:main Dec 12, 2022
mergify bot pushed a commit that referenced this pull request Dec 12, 2022
* fix in handling states and purging

* changelog

* increase coverage

* cr fixes

* remove code duplication in tests

(cherry picked from commit 01f9d43)
mergify bot pushed a commit that referenced this pull request Dec 12, 2022
* fix in handling states and purging

* changelog

* increase coverage

* cr fixes

* remove code duplication in tests

(cherry picked from commit 01f9d43)
aspacca pushed a commit that referenced this pull request Dec 15, 2022
* fix in handling states and purging

* changelog

* increase coverage

* cr fixes

* remove code duplication in tests

(cherry picked from commit 01f9d43)

Co-authored-by: Andrea Spacca <[email protected]>
aspacca pushed a commit that referenced this pull request Dec 15, 2022
* fix in handling states and purging

* changelog

* increase coverage

* cr fixes

* remove code duplication in tests

(cherry picked from commit 01f9d43)

Co-authored-by: Andrea Spacca <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* fix in handling states and purging

* changelog

* increase coverage

* cr fixes

* remove code duplication in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] AWS S3 direct listing input: states registry purged only on "stored" and not on "error"
3 participants