Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Refactor browser summary as a job wrapper #33819

Merged
merged 6 commits into from
Dec 13, 2022
Merged

[Heartbeat] Refactor browser summary as a job wrapper #33819

merged 6 commits into from
Dec 13, 2022

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Nov 25, 2022 •
edited
Loading

What does this PR do?

Fixes #33374.

Refactors browser summary to be a job wrapper so it can react to job errors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.6.0 labels Nov 25, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 25, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-13T11:42:46.219+0000

  • Duration: 49 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 1889
Skipped 25
Total 1914

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap marked this pull request as ready for review November 25, 2022 11:05
@emilioalvap emilioalvap requested a review from a team as a code owner November 25, 2022 11:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@emilioalvap
Copy link
Collaborator Author

/test

andrewvc
andrewvc approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the one change

heartbeat/monitors/wrappers/wrappers.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@emilioalvap emilioalvap merged commit 53becc2 into elastic:main Dec 13, 2022
@emilioalvap emilioalvap added the backport-v8.6.0 Automated backport with mergify label Dec 13, 2022
mergify bot pushed a commit that referenced this pull request Dec 13, 2022
@emilioalvap @mergify
[Heartbeat] Refactor browser summary as a job wrapper (#33819)
6b3517e 
* Refactor browser summary as a job wrapper

* Fix unit tests

* Update heartbeat/monitors/wrappers/wrappers.go

Co-authored-by: Andrew Cholakian <[email protected]>

* Update changelog

Co-authored-by: Andrew Cholakian <[email protected]>
(cherry picked from commit 53becc2)
@mergify mergify bot mentioned this pull request Dec 13, 2022
Merged
emilioalvap added a commit that referenced this pull request Dec 13, 2022
@mergify @emilioalvap
[Heartbeat] Refactor browser summary as a job wrapper (#33819) (#34033)
f555341 
* Refactor browser summary as a job wrapper

* Fix unit tests

* Update heartbeat/monitors/wrappers/wrappers.go

Co-authored-by: Andrew Cholakian <[email protected]>

* Update changelog

Co-authored-by: Andrew Cholakian <[email protected]>
(cherry picked from commit 53becc2)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
@emilioalvap emilioalvap removed their assignment Dec 20, 2022
@justinkambic justinkambic self-assigned this Dec 20, 2022
@justinkambic
Copy link
Contributor

Post-FF testing LGTM

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@emilioalvap @andrewvc @chrisberkhout
[Heartbeat] Refactor browser summary as a job wrapper (#33819)
2d8e5c8 
* Refactor browser summary as a job wrapper

* Fix unit tests

* Update heartbeat/monitors/wrappers/wrappers.go

Co-authored-by: Andrew Cholakian <[email protected]>

* Update changelog

Co-authored-by: Andrew Cholakian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees

@justinkambic justinkambic

Labels
backport-v8.6.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Monitor reports as summary up: 1 when monitor.status is down and 0 steps ran
4 participants
@emilioalvap @elasticmachine @justinkambic @andrewvc