filebeat/input/{tcp,udp}: don't panic on nil addresses #33837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Filebeat
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
requested review from
cmacknz and
fearful-symmetry
and removed request for
a team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Nov 28, 2022
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it.
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it. (cherry picked from commit 105fbda)
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it. (cherry picked from commit 105fbda)
efd6
added a commit
that referenced
this pull request
Nov 28, 2022
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it. (cherry picked from commit 105fbda) Co-authored-by: Dan Kortschak <[email protected]>
efd6
added a commit
that referenced
this pull request
Nov 29, 2022
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it. (cherry picked from commit 105fbda) Co-authored-by: Dan Kortschak <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The callback may be called with a nil RemoteAddr in the metadata parameter, so ensure that this is not nil before attempting to deference it.
Why is it important?
This bug causes loss of service.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs