-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lockfile under fleet mode #33988
Disable lockfile under fleet mode #33988
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks straightforward enough. Likely we have to let this marinate on main for a while to see if anything surprising happens.
Kudos, SonarCloud Quality Gate passed! |
* diable lockfile under fleet mode * update docs * add changelog (cherry picked from commit 493b3a4) # Conflicts: # libbeat/cmd/instance/beat.go
* Disable lockfile under fleet mode (#33988) * diable lockfile under fleet mode * update docs * add changelog (cherry picked from commit 493b3a4) # Conflicts: # libbeat/cmd/instance/beat.go * Resolve conflict in beat.go Co-authored-by: Alex K <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>
* diable lockfile under fleet mode * update docs * add changelog
What does this PR do?
This is the other half of the fix for #31670 (comment)
This disables the lockfile when the beat is running under elastic-agent.
I've tested this, but I'm not 100% sure on what, if any, unintentional behaviors this might cause. Theoretically elastic-agent should be responsible for correctly starting/restarting a beat, and elastic-agent has its own lockfile.
Why is it important?
We're having a lot of issues with lockfiles under elastic-agent.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.