Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #34761) Stop re-using processors defined in the config #34764

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 7, 2023

This is an automatic backport of pull request #34761 done by Mergify.
Cherry-pick of 5cfe62c has failed:

On branch mergify/bp/7.17/pr-34761
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 5cfe62cb2f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   filebeat/channel/runner.go
	both modified:   libbeat/processors/safe_processor.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Stop re-using processors defined in the config

After introducing the `SafeProcessor` wrapper in
#34647 we started returning
errors when a processor is being used after its `Close` function has
been called.

This led to dropped events and error spam in logs but also confirmed
that the root cause of the problem was not just a race condition on
`Close` but re-used processors somewhere.

After a long investigation such code that's re-using processors was
finally found.

This is the change that removes re-using the processors and
instantiates them on each input restart.

* Fix linter issues

* Add changelog entry

(cherry picked from commit 5cfe62c)

# Conflicts:
#	filebeat/channel/runner.go
#	libbeat/processors/safe_processor.go
@mergify mergify bot requested a review from a team as a code owner March 7, 2023 22:17
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 7, 2023
@mergify mergify bot requested review from cmacknz and faec and removed request for a team March 7, 2023 22:17
@mergify mergify bot assigned rdner Mar 7, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2023
@botelastic
Copy link

botelastic bot commented Mar 7, 2023

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-08T10:36:28.913+0000

  • Duration: 87 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 22239
Skipped 1566
Total 23805

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner
Copy link
Member

rdner commented Mar 8, 2023

Both checks are failing because of:

Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/s/systemd/libsystemd-dev_249.11-0ubuntu3.6_amd64.deb 404 Not Found [IP: 52.147.219.192 80]

Seems like they cannot install the package from that URL anymore.

@rdner rdner merged commit 48a5664 into 7.17 Mar 8, 2023
@rdner rdner deleted the mergify/bp/7.17/pr-34761 branch March 8, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants