Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Add nil check to diagnostics processor serializer #35698

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Jun 6, 2023

What does this PR do?

Closes #35635.
Related to #35031.

TL;DR: We are seeing segfaults when running elastic-agent diagnostics on heartbeat policies. Traced back to a nested nil access. AFAIK, there're other beats affected by the same problem.

  • Add nil check to diagnostics processor serializer.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Build agent locally.
  • Enroll an agent in a synthetics policy.
  • Run elastic-agent diagnostics.
  • Check no segfault error is reported and .zip contains parsed synthetic policies.

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Elastic-Agent Label for the Agent team backport-v8.8.0 Automated backport with mergify labels Jun 6, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner June 6, 2023 12:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 6, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T16:04:25.489+0000

  • Duration: 71 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 27307
Skipped 2007
Total 29314

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap enabled auto-merge (squash) June 6, 2023 14:37
@emilioalvap emilioalvap merged commit c81e9b2 into elastic:main Jun 7, 2023
mergify bot pushed a commit that referenced this pull request Jun 7, 2023
* Add nil check to diagnostics processor serializer

* Add changelog

(cherry picked from commit c81e9b2)
emilioalvap added a commit that referenced this pull request Jun 8, 2023
#35713)

* Add nil check to diagnostics processor serializer

* Add changelog

(cherry picked from commit c81e9b2)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.8.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Elastic Agent diagnostics ZIP does not contain Synthetics data (Heartbeat error)
3 participants