-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Add nil check to diagnostics processor serializer #35698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilioalvap
added
bug
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
Team:Elastic-Agent
Label for the Agent team
backport-v8.8.0
Automated backport with mergify
labels
Jun 6, 2023
Pinging @elastic/uptime (Team:Uptime) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 6, 2023
Collaborator
cmacknz
reviewed
Jun 6, 2023
cmacknz
approved these changes
Jun 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Add nil check to diagnostics processor serializer * Add changelog (cherry picked from commit c81e9b2)
emilioalvap
added a commit
that referenced
this pull request
Jun 8, 2023
#35713) * Add nil check to diagnostics processor serializer * Add changelog (cherry picked from commit c81e9b2) Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.8.0
Automated backport with mergify
bug
Team:Elastic-Agent
Label for the Agent team
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #35635.
Related to #35031.
TL;DR: We are seeing segfaults when running
elastic-agent diagnostics
on heartbeat policies. Traced back to a nestednil
access. AFAIK, there're other beats affected by the same problem.nil
check to diagnostics processor serializer.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
elastic-agent diagnostics
..zip
contains parsed synthetic policies.